Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured product placeholder image not applying default styles and/or presets #2685

Closed
kimberlyoleiro opened this issue Jun 1, 2023 · 2 comments

Comments

@kimberlyoleiro
Copy link

User Story As a merchant installing a new theme to use for my online store, I should be able to see an accurate representation of what my theme will look like with or without placeholder content. What I see by default, should reflect what I'll see when I upload a real image

Ultimate Goal: Achieve a 1:1 experience between placeholders images and real images

More context: With the introduction of new placeholder content, and fresh eyes on the topic, we noticed some inconsistencies between the empty and populated states with images.

Identified Problem:

The featured product section placeholder image is not applying the default styles that a merchant would see when they connect a product

Image
Image

Expected behaviour

  • The featured product section placeholder image should appear with the same styles as a connected product image would
@lougoncharenko
Copy link
Contributor

@kimberlyoleiro I believe this issue was solved in this PR: Fix media, product, and collection cards placeholder

In the video below, I apply different presets that apply to placeholder images.

Screen.Recording.2023-07-05.at.10.36.48.AM.mov

@kimberlyoleiro
Copy link
Author

this has been resolved in #2682

Screenshot 2023-07-10 at 10 48 13 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants