Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Pricing: variants that dont have vol pricing will have a big spacing gap #2932

Closed
sofiamatulis opened this issue Aug 1, 2023 · 0 comments
Assignees

Comments

@sofiamatulis
Copy link
Contributor

sofiamatulis commented Aug 1, 2023

Original comment: #2889 (comment)

Option 1: Show greyed out table

  • All of the elements will be in the same position and no layout shift
  • If blocks are re-ordered it wont affect it
  • More real estate being used but no real information is there

Option 2: Remove the extra spacing

  • Layout shift will occur when you change variants
  • Especially if blocks are re-ordered, the layout shift can be more jarring
  • Real estate being used with information that is not useful (greyed out blocks). At the same time, unavailable variants would not offer any information to begin with

Decision: Option 2

Extra context:

Option 2 is more future proof in the sense that if we do add new information in the future, its easier to just not show it instead of having to think what to do with the new spacing for the new information.

We already have some small layout shift because there may be a table that the show more exists or the unit price exists or not. But some layout shift already exists:
https://screenshot.click/02-44-v1jzm-qoxnm.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant