Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rexml gem dependency cannot load such file -- rexml/document (LoadError) #381

Closed
jana4u opened this issue Oct 14, 2024 · 2 comments

Comments

@jana4u
Copy link

jana4u commented Oct 14, 2024

rexml was previously added through rubocop, but they recently removed it: rubocop/rubocop#13165

But seems like it is still necessary for ERB Lint itself:

  bundle exec erblint --lint-all
bundler: failed to load command: erblint (/home/runner/work/app/app/vendor/bundle/ruby/3.2.0/bin/erblint)
<internal:/opt/hostedtoolcache/Ruby/3.2.4/x64/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:38:in `require': cannot load such file -- rexml/document (LoadError)
	from <internal:/opt/hostedtoolcache/Ruby/3.2.4/x64/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:38:in `require'
	from /home/runner/work/app/app/vendor/bundle/ruby/3.2.0/gems/erb_lint-0.6.0/lib/erb_lint/reporters/junit_reporter.rb:3:in `<top (required)>'

This is when using erb_lint (0.6.0) with rubocop (1.66.1).

This can be "fixed" by adding gem "rexml", require: false to Gemfile, but erb_lint should have its dependencies handled better.

@Mangara
Copy link
Contributor

Mangara commented Oct 16, 2024

It looks like it's fixed in #374, so we just need a new release that contains it.

@jana4u
Copy link
Author

jana4u commented Nov 8, 2024

Fixed in 0.7.0

@jana4u jana4u closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants