fix: trigger onViewableItemsChanged when data changes #1259
+23
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FlashList does not re-trigger
onViewableItemsChanged
callback if the data prop changes. This also varies from React Native's FlatList. The function nameonViewableItemsChanged
is such that it should trigger if data changes (because it can change the visible items). React Native'sVirtualizedList
uses a similar approach used in this PR to re-trigger the viewability state in didUpdate.Fixes (issue #)
#566
Reviewers’ hat-rack 🎩
onViewableItemsChanged
fires when data prop changes.Screenshots or videos (if needed)
Checklist