Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pnpm #848

Open
frandiox opened this issue Mar 8, 2022 · 5 comments
Open

Migrate to pnpm #848

frandiox opened this issue Mar 8, 2022 · 5 comments
Labels
dx Improvements to Developer Tooling & Developer Experience

Comments

@frandiox
Copy link
Contributor

frandiox commented Mar 8, 2022

PNPM is a faster and more modern alternative to Yarn v1. Most of the Vite ecosystem is using it, including Vite itself. Also, Vite CI has problems running Hydrogen with Yarn v1.

We already tried this back in Oct 2021, and we had issues with symlinks in pnpm.

Things to check:

  • Compatibility with pnpm symlinks
  • Peer depedencies support (do we need --shamefully-hoist?)
  • Make sure standalone apps work the same way as in-repo examples
@frandiox frandiox added bug Something isn't working dx Improvements to Developer Tooling & Developer Experience and removed bug Something isn't working labels Mar 8, 2022
@michenly
Copy link
Contributor

michenly commented Mar 8, 2022

  • Check to ensure PNPM works with shipit

@frehner
Copy link
Contributor

frehner commented Mar 8, 2022

Currently having issues with upgrading eslint in our repos, and the culprit appears to be yarn v1... 🤔

@benjaminsehl
Copy link
Member

I'd love to have pnpm support!

@tylerhellner
Copy link

tylerhellner commented Jun 27, 2022

The monorepo of our organization runs on pnpm. I'd love to see support in the future so I can take it out of submodule status. If the team needs a hand with the PR, I'd be happy to look into it.

@frandiox
Copy link
Contributor Author

@tylerhellner We are not currently working on this yet so feel free to take a stab at it 👍
The main priority is that our local development in the repo templates/examples should behave the same way as running standalone apps. This might be affected by differences in symlinks, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Improvements to Developer Tooling & Developer Experience
Projects
None yet
Development

No branches or pull requests

5 participants