Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't blow up when no pods retrieved for DS #242

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Don't blow up when no pods retrieved for DS #242

merged 1 commit into from
Feb 20, 2018

Conversation

KnVerey
Copy link
Contributor

@KnVerey KnVerey commented Feb 20, 2018

As seen in a cluster-services deploy:

lib/kubernetes-deploy/kubernetes_resource/daemon_set.rb:41:in `fetch_logs': undefined method `fetch_logs' for nil:NilClass (NoMethodError)
	from lib/kubernetes-deploy/kubernetes_resource.rb:149:in `sync_debug_info'
	from lib/kubernetes-deploy/concurrency.rb:13:in `each'
	from lib/kubernetes-deploy/concurrency.rb:13:in `block (2 levels) in split_across_threads'

stefanmb
stefanmb approved these changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@stefanmb stefanmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems foolproof, LGTM!

@KnVerey KnVerey merged commit 83ffb31 into master Feb 20, 2018
@KnVerey KnVerey deleted the ds_bugfix branch February 20, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanmb stefanmb stefanmb approved these changes

@karanthukral karanthukral karanthukral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KnVerey @stefanmb @karanthukral @klautcomputing