Directory based kubectl apply when there are more than 1k resources #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tests to not care about message order
dturn
force-pushed
the
support-large-number-of-resources
branch
from
fa15652
to
5981c2c
Compare
|
Changes are in. Would like feedback on the ensure block vs wrapping almost the entire |
klautcomputing
approved these changes
Apr 2, 2018
KnVerey
approved these changes
Apr 2, 2018
I don't have a strong preference since the nesting doesn't get too crazy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploys with thousands of resources can fail with
Argument list too long - kubectl (Errno::E2BIG). This happens because we render each resource to its own file and then pass all of the files to kubectl apply via the-f` flag. This pr detects when there are greater than 1k resources copies them to a temp directory and passes only the directory to kubectl apply.cc: @dwradcliffe