Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Nokogiri #56

Closed
BuonOmo opened this issue Oct 5, 2024 · 2 comments
Closed

No Nokogiri #56

BuonOmo opened this issue Oct 5, 2024 · 2 comments

Comments

@BuonOmo
Copy link

BuonOmo commented Oct 5, 2024

Hi @peterzhu2118,

I tend to try not to use nokogiri when not necessary since it is a very huge monster. Would consider a pull request to replace it ? Using for instance Ox ?

@peterzhu2118
Copy link
Member

What issues are you running with Nokogiri? Nokogiri provides precompiled gems on most common platforms, so it shouldn't be difficult to install.

With the introduction of Feature #19993 in Ruby, starting Ruby 3.4, ruby_memcheck will by default no longer apply its heuristics on Valgrind and instead enable RUBY_FREE_AT_EXIT. This means that ruby_memcheck will become a simple wrapper around Valgrind.

@BuonOmo
Copy link
Author

BuonOmo commented Oct 5, 2024

Nokogiri provides precompiled gems on most common platforms, so it shouldn't be difficult to install.

Both on Github Action and my M1 mac it is the slower installation (maybe just download time though!)

With the introduction of Feature #19993 in Ruby, starting Ruby 3.4, ruby_memcheck will by default no longer apply its heuristics on Valgrind and instead enable RUBY_FREE_AT_EXIT. This means that ruby_memcheck will become a simple wrapper around Valgrind.

Yep I could use valgrind directly then, super nice :) I can definitely wait for that and not care about replacing nokogiri. Closing.

@BuonOmo BuonOmo closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants