Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

[Bug]: Ignore syntax changed? #2118

Closed
2 tasks done
pm-zr opened this issue Mar 3, 2022 · 2 comments · Fixed by #2122
Closed
2 tasks done

[Bug]: Ignore syntax changed? #2118

pm-zr opened this issue Mar 3, 2022 · 2 comments · Fixed by #2122
Assignees
Labels
type:bug Something isn't working

Comments

@pm-zr
Copy link

pm-zr commented Mar 3, 2022

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

What type of project are you working on?

theme

Expected behavior

I have a pull script that looks similar to the following:

#! /bin/bash
shopify theme pull src --ignore assets/theme.scss --ignore assets/css.css --ignore assets/component-*.css

previously, this worked.

new syntax needed:

shopify theme pull src --ignore assets/theme.scss assets/css.css assets/component-*.css

Actual behavior

all the specified ignored files were in fact pulled except those in the first ignore flag

This broke from 2.11.0 -> 2.13.0 confirmed by downgrading shopify CLI.

Stack trace

No response

Reproduction steps

  1. start with a fresh theme.
  2. deploy the theme to remote shopify theme push
  3. delete 2 random files
  4. ignore both on a pull with shopify --ignore file1 --ignore file2
  5. see that the second file is pulled while the first is not
  6. delete both files again
  7. ignore both on a pull with shopify --ignore file1 file2
  8. see that both files are now ignored

Operating System

Mac os monterey

CLI version (run shopify version if you're not sure)

2.13.0

Shell

zsh, bash

Ruby version (run ruby -v if you're not sure)

ruby 2.6.8p205 (2021-07-07 revision 67951) [universal.x86_64-darwin21]

What language and version are you using in your application?

NA

@pm-zr pm-zr added the type:bug Something isn't working label Mar 3, 2022
@pm-zr
Copy link
Author

pm-zr commented Mar 3, 2022

#2066
#2025

@pm-zr
Copy link
Author

pm-zr commented Mar 3, 2022

It would be preferable for us to support multiple ignore flags (either as opposed to or in addition to multiple args for a single flag if that is the new syntax)

@karreiro karreiro linked a pull request Mar 7, 2022 that will close this issue
4 tasks
@karreiro karreiro self-assigned this Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants