Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Enable Theme Access passwords for theme serve #2681

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Nov 9, 2022

WHY are these changes introduced?

Related to https://github.com/Shopify/shopify-cli-planning/issues/376

WHAT is this pull request doing?

Proxies Storefront Renderer requests from the dev server through Theme Access API when a password is provided

How to test your changes?

Once https://github.com/Shopify/theme-access/pull/2463 and https://github.com/Shopify/storefront-renderer/pull/15845 are released, it can be tested with: SHOPIFY_SHOP=your-shop SHOPIFY_CLI_ADMIN_AUTH_TOKEN=password SHOPIFY_CLI_STOREFRONT_RENDERER_AUTH_TOKEN=password shopify theme serve

Otherwise, it requires updating the Theme Access URL to local/staging and hard-coding an access token for SFR here.

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrementing this when releasing).
  • I've included any post-release steps in the section above (if needed).

@gonzaloriestra gonzaloriestra marked this pull request as ready for review November 9, 2022 11:56
@gonzaloriestra gonzaloriestra requested review from a team November 9, 2022 11:56
Copy link
Contributor

@mgmanzella mgmanzella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🔥 left one question

lib/shopify_cli/theme/dev_server/proxy.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@mgmanzella mgmanzella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.

→ If there's no activity within a week, then a bot will automatically close this.

Thanks for helping to improve Shopify's dev tooling and experience.

@gonzaloriestra gonzaloriestra merged commit 73693d7 into main Dec 19, 2022
@gonzaloriestra gonzaloriestra deleted the enable-theme-passwords-dev branch December 19, 2022 15:17
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems December 19, 2022 16:05 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants