This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Enable Theme Access passwords for theme serve #2681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to https://github.com/Shopify/shopify-cli-planning/issues/376
WHAT is this pull request doing?
Proxies Storefront Renderer requests from the dev server through Theme Access API when a password is provided
How to test your changes?
Once https://github.com/Shopify/theme-access/pull/2463 and https://github.com/Shopify/storefront-renderer/pull/15845 are released, it can be tested with:
SHOPIFY_SHOP=your-shop SHOPIFY_CLI_ADMIN_AUTH_TOKEN=password SHOPIFY_CLI_STOREFRONT_RENDERER_AUTH_TOKEN=password shopify theme serve
Otherwise, it requires updating the Theme Access URL to local/staging and hard-coding an access token for SFR here.
Update checklist