This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Do not replace_asset_urls
in font bodies
#2721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes Shopify/cli#1199
Starting with Ruby 3.2 – Homebrew formula just says
depends_on "ruby"
, so that’s why such kind of issues appear now –body.join.gsub
raises the errorinvalid byte sequence in UTF-8
whenbody.join
is a font body (which of course doesn’t contain any URLs or other readable characters).WHAT is this pull request doing?
replace_asset_urls
when path starts with/fonts
.gsub
able" strings are beinggsub
ed and the sameArgumentError
containing the messageinvalid byte sequence
is raised, body will simply be returned without any replacements.How to test your changes?
Test it with both Ruby 3.1 and 3.2:
cd
into a theme directoryDEBUG=true shopify theme serve
http://127.0.0.1:9292/
Post-release steps
Update checklist