You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
There's a check for undefined variables which works well, but all it seems to be doing is checking for the existence of an assignment, not the validity of the assignment.
Currently, I can attempt to access a variable before it's been assigned and it's considered valid.
If you look in ESLint, this would throw an undefined error.
Expected
{{ cool }}
{% assigncool = true %}
// Variable "cool" used before being assigned.
👋🏻 Hi @ConduciveMammal! Thanks for reporting this. Unfortunately the Ruby version of theme check has been deprecated for some time. Would you be able to confirm you are still having issues when using our maintained version of theme check? This is done using either the latest version of the Shopify CLI, or via the Shopify Liquid Visual Studio Code extension.
If you are still having issues, please raise an issue over in the CLI or theme tools repositories. Thanks!
Describe the bug
There's a check for undefined variables which works well, but all it seems to be doing is checking for the existence of an assignment, not the validity of the assignment.
Currently, I can attempt to access a variable before it's been assigned and it's considered valid.
If you look in ESLint, this would throw an undefined error.
Expected
Actual
Debugging information
The text was updated successfully, but these errors were encountered: