Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[theme-manipulate] upload accepts patterns but has multiple issues #11

Closed
nickjj opened this issue Dec 4, 2014 · 4 comments
Closed

Comments

@nickjj
Copy link

nickjj commented Dec 4, 2014

I noticed you had a ticket open for manipulate->download but this affects manipulate->upload.

I was able to theme-manipulate upload assets/* with the December 2nd pre-release, but there's multiple bugs:

  1. It does not properly handle binary assets still, they aren't correct files.
  2. Trying to just upload * fails, but this also means doing snippets/* fails too because eventually it hits the customers/ directory.

For the second issue it panics saying customers is a directory at:
https://github.com/csaunders/phoenix/blob/master/cmd/theme-manipulate/upload.go#L11

@csaunders
Copy link
Contributor

What kinds of binary assets are you dealing with here? Stuff like mp4s and pdfs?

@nickjj
Copy link
Author

nickjj commented Dec 15, 2014

Images, jpg and png formats.

@csaunders
Copy link
Contributor

Hmmm interesting because I was testing with images and they were uploading fine. This is with the nightly build and everything?

@nickjj
Copy link
Author

nickjj commented Dec 15, 2014

With the December 2nd nightly build. Using xubuntu 14.04 32bit. It would create the files but they would be empty by the time they were visible in the web UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants