Dependabot PRs use version information from incorrect repo #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked the code of depndabot: https://github.com/dependabot/dependabot-core/blob/2f0db3e851ba2cc43d0b6dcd70da5e69d5b63eb6/bundler/lib/dependabot/bundler/metadata_finder.rb Adding source_code_uri and changelog_uri |
miry
force-pushed
the
changelog
branch
5 times, most recently
from
ed719b4
to
545a4e6
Compare
miry
force-pushed
the
changelog
branch
2 times, most recently
from
5d90eb5
to
598bbf7
Compare
tinnet
reviewed
Mar 22, 2022
tinnet
reviewed
Mar 22, 2022
tinnet
approved these changes
Mar 22, 2022
Strech
approved these changes
Mar 22, 2022
Create CHANGELOG.md with 2 entries. Update gemspec to have links to CHANGELOG.md. Co-authored-by: Martin Contento <67421+tinnet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
toxiproxygem is fed by releases from thetoxiproxy-rubyrepo, but Dependabot gem bump PRs for this gem will link to and source the changelog from https://github.com/Shopify/toxiproxy/ instead, which is confusing and misleading. An example from a private repo: https://github.com/Shopify/pay/pull/14119This may be caused by the gemspec file referring to https://github.com/Shopify/toxiproxy for most fields, including the homepage.