Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo is being drawn on top of the qr code #15

Closed
kostia1st opened this issue Aug 29, 2024 · 3 comments
Closed

Logo is being drawn on top of the qr code #15

kostia1st opened this issue Aug 29, 2024 · 3 comments
Labels

Comments

@kostia1st
Copy link
Contributor

Describe the bug
Well, I'd expect the logo to be drawn at the center, with the actual qr code floating around it.
Instead, the code itself covers the entire rect area including the center, and the logo is drawn on top of it.

To Reproduce

  return await getPNG(value, {
    bgColor,
    color: fgColor,
    logo,
    logoWidth: 20,
    logoHeight: 20,
    parse_url: true,
    borderRadius: 50,
    size: 100,
  });

Expected behavior
I'd expect the logo to be drawn at the center, with the actual qr code floating around it.

Screenshots
chrome_CElz2KPcAq

Desktop (please complete the following information):

  • OS: windows 11
  • Browser Chrome 128
  • Version 9.3.0
@gugu
Copy link
Member

gugu commented Aug 31, 2024

That's how logos in QR code work - they utilize redundancy in QR code and cover part of QR code with image. If you want to hide dots partially covered by logo - feel free to send a PR for that

@kostia1st
Copy link
Contributor Author

Alright, will try to prepare one

Copy link

github-actions bot commented Sep 1, 2024

🎉 This issue has been resolved in version 9.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants