Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to porting Deoplete to Vim 8? #339

Closed
lifepillar opened this issue Sep 11, 2016 · 29 comments
Closed

Any plan to porting Deoplete to Vim 8? #339

lifepillar opened this issue Sep 11, 2016 · 29 comments

Comments

@lifepillar
Copy link

I have started using Deoplete and so far I love it. If only it worked in Vim… Do you have any plan to port Deoplete (or Neocomplete) to Vim 8, leveraging the new asynchronous features of Vim?

@rafaelndev
Copy link

rafaelndev commented Sep 12, 2016

Read: 63e7bd9

@lifepillar
Copy link
Author

I see. Just out of curiosity, do you think that Vim's channels and/or jobs could be used to build a plugin with comparable features and performance to deoplete? Or does the neovim-python API provide some essential functionality?

@Shougo
Copy link
Owner

Shougo commented Sep 12, 2016

No plan to support Vim8 API in neocomplete

To support Vim8 API in deoplete, neovim-python compatibility API is needed. I think it can be implemented. I don't want to create the API though(I have not much time!).
If it is created, I will support it.

Just out of curiosity, do you think that Vim's channels and/or jobs could be used to build a plugin with comparable features and performance to deoplete?

I think deoplete in Vim is slower than deoplete in neovim.
It is RPC performance problem(MessagePackRPC vs JSON RPC).

@Shougo Shougo closed this as completed Sep 12, 2016
@lifepillar
Copy link
Author

I think deoplete in Vim is slower than deoplete in neovim.
It is RPC performance problem(MessagePackRPC vs JSON RPC).

Crystal clear, thanks!

@Asheq
Copy link

Asheq commented Nov 30, 2016

Hey @Shougo , I saw in the video below that Vim8 support for deoplete is on your roadmap. Is this true as of today? Does this mean that you no longer need the neovim-python compatibility API?

https://www.youtube.com/watch?v=u3ZsAVWCuMM

Thanks!

@jsfaint
Copy link

jsfaint commented Dec 1, 2016

@Asheq The link is talking about Denite.nvim, not deoplete.nvim.
denite.vim is a replacement of unite.vim for neovim and vim8

@Asheq
Copy link

Asheq commented Dec 1, 2016

@jsfaint Yup, I knew that, but there's a section in the video that the Dark Vim Master calls "secret topics". One of the things he mentions is:

My next work is to add Vim8 support in deoplete.nvim

The particular point in the video is the 15 minute mark (http://www.youtube.com/watch?v=u3ZsAVWCuMM&t=15m47s) :)

@jsfaint
Copy link

jsfaint commented Dec 1, 2016

@Asheq wow~~ Good news, thank you~

@Shougo Shougo reopened this Dec 1, 2016
@Shougo
Copy link
Owner

Shougo commented Dec 1, 2016

Hey @Shougo , I saw in the video below that Vim8 support for deoplete is on your roadmap. Is this true as of today?

This is true. To support Vim 8 is on the current load map.

Does this mean that you no longer need the neovim-python compatibility API?

I need neovim-python compatibility API!
But anyone does not create it.
So I have decided to create it. It takes much time.

Note: This does not mean that I don't want to use neovim.
My main editor is still neovim and it is better.
This is just backup plan.

neocomplete will be deprecated.

@Asheq
Copy link

Asheq commented Dec 2, 2016

Thanks, I would like to use neovim, but I'm on Windows right now and there are currently still some problems with neovim on Windows. When Windows gets first-class support in neovim, I and many others will consider switching over :) ... For right now, I'm using Vim8 + neocomplete.

@jwmann
Copy link

jwmann commented Jan 12, 2017

Very excited for a Vim 8 port! 👍

@prabirshrestha
Copy link

If you get the latest neovim from master it now works on windows. I have deoplete with typescript currently working on windows.

@jwmann
Copy link

jwmann commented Jan 12, 2017

I'm not sure what that has to do with Vim 8 😕

@wsdjeg
Copy link
Contributor

wsdjeg commented Jan 12, 2017

@jwmann I think you can use neovim. I also use neovim with deoplete in win7, but most of my time is in linux.

@jwmann
Copy link

jwmann commented Jan 12, 2017

@wsdjeg I'm not having any issues using neovim, I would just prefer using Vim 8 as most of my plugins still aren't neovim compatible.

@Shougo
Copy link
Owner

Shougo commented Jan 14, 2017

I'm not sure what that has to do with Vim 8 😕

It needs the implementation of neovim-python.
And Vim8 channel/job interface is very complicated.
I don't have much time now...

@jwmann
Copy link

jwmann commented Jan 14, 2017

It needs the implementation of neovim-python.
And Vim8 channel/job interface is very complicated.
I don't have much time now...

@Shougo
I understand, I'm not expecting it to come quickly.
I just want to show my support for it! 👍 😄

@roxma
Copy link
Contributor

roxma commented Feb 20, 2017

vim-hug-neovim-rpc might help this vim8 support issue.

For anyone getting interested, please help me improve it 😄

@wsdjeg
Copy link
Contributor

wsdjeg commented Feb 20, 2017

@roxma nice work!

@jwmann
Copy link

jwmann commented Feb 20, 2017

@roxma Great idea! 😄

@Shougo
Copy link
Owner

Shougo commented Feb 20, 2017

vim-hug-neovim-rpc might help this vim8 support issue.

Yes, it is the needed.
I can add Vim8 support using it.
But... I must understand the implementation and implement the handler for deoplete.
It takes much time and I am very busy.

The help is wanted.

@roxma
Copy link
Contributor

roxma commented Oct 14, 2017

This plugin might also be helpful for vim 8 support:

https://github.com/roxma/nvim-yarp#example-for-existing-neovim-rplugin-porting-to-vim-8

As mentioned in the README, I have write a small example on porting existing neovim rplugin to vim 8.

But it seems deoplete is using the old style rplugin api. I'm not sure how much work needs to be done to conver it to new style api (e.g. @neovim.function, @neovim.command).

@Shougo
Copy link
Owner

Shougo commented Oct 15, 2017

I don't want to depends other plugin.

But it seems deoplete is using the old style rplugin api. I'm not sure how much work needs to be done to conver it to new style api (e.g. @neovim.function, @neovim.command).

It is not old style. deoplete uses RPC protocol.

And nvim-yarp seems not support async.

@Shougo
Copy link
Owner

Shougo commented Oct 15, 2017

I don't fully understand.

I will test the plugin.

@Shougo
Copy link
Owner

Shougo commented Oct 15, 2017

@roxma I have tested it, but it is freezed. Why?

#553

@Shougo
Copy link
Owner

Shougo commented Oct 15, 2017

The test seems works.

@Shougo
Copy link
Owner

Shougo commented Oct 16, 2017

I will merge #553 on the weekend.
The issue will be closed.
Please wait.

@wsdjeg
Copy link
Contributor

wsdjeg commented Oct 16, 2017

nice worK

@Shougo
Copy link
Owner

Shougo commented Oct 22, 2017

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants