Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeCov integration for test coverage analytics #15

Closed
snobbee opened this issue Nov 21, 2024 · 12 comments
Closed

CodeCov integration for test coverage analytics #15

snobbee opened this issue Nov 21, 2024 · 12 comments
Assignees
Labels
testing Improvements or additions to tests

Comments

@snobbee
Copy link
Collaborator

snobbee commented Nov 21, 2024

Add codecov in order to get an automatic report of each new PR test coverage and set some goals to encourage community to improve their test coverage.

@snobbee snobbee added the testing Improvements or additions to tests label Nov 21, 2024
@snobbee snobbee self-assigned this Nov 21, 2024
@snobbee
Copy link
Collaborator Author

snobbee commented Nov 22, 2024

Image

@jkbrooks I can’t setup codecov using my github handle as I am not an eliza org member, could you sign in to codecov.io with your github handle and enable codecov on the eliza repo from the ai16z org.

There are multiple steps that you would need to go through, we can setup a meeting where we can do that together, here is an example of the steps I am seeing when selecting Sifchain > sa-eliza repo:

Image

@jkbrooks
Copy link

Sure, are you free now? @snobbee

@jkbrooks
Copy link

Seems like no, I will coordinate with you more on slack

@snobbee
Copy link
Collaborator Author

snobbee commented Nov 22, 2024

sure, will do in the call

@snobbee
Copy link
Collaborator Author

snobbee commented Nov 22, 2024

for context, @jkbrooks requested shawn (ai16z) to help with that task, waiting for his feedback

@snobbee
Copy link
Collaborator Author

snobbee commented Nov 25, 2024

@jkbrooks did you get any feedback from Shawn about that?

@jkbrooks
Copy link

@snobbee it's "Shaw"

It's very late for him right now, but I will bump this with him tomorrow.

@snobbee
Copy link
Collaborator Author

snobbee commented Nov 25, 2024

FYI sounds like @jkbrooks will be able to be granted "admin" access so we will be able to move forward with this ticket.

@jkbrooks
Copy link

jkbrooks commented Dec 2, 2024

We did a pretty good job here, but now we need to make an announcement to the community and coordinate. Someone already disabled the test, and we aren't sure why. Our intention is that this is not blocking, we just have a target. We believe the current code coverage is around 30%. Our target for the repo is 70%. We need to agree with the community on what the target should be and also on what should happen as for blockers and identify what potential blockers may have existed.

elizaOS@c9f27be#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR41

@jkbrooks jkbrooks self-assigned this Dec 2, 2024
@jkbrooks
Copy link

jkbrooks commented Dec 3, 2024

@snobbee please close after you revert elizaOS@c9f27be#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR37 assuming all tests work othewise please comment on any additional things to be addressed

@jkbrooks jkbrooks removed their assignment Dec 3, 2024
@snobbee
Copy link
Collaborator Author

snobbee commented Dec 7, 2024

PR ready to review elizaOS#880

@snobbee
Copy link
Collaborator Author

snobbee commented Dec 12, 2024

PR created elizaOS#1019 to generate coverage files for codecov cc @monilpat @jkbrooks

@snobbee snobbee closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements or additions to tests
Projects
None yet
Development

No branches or pull requests

2 participants