-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeCov integration for test coverage analytics #15
Comments
@jkbrooks I can’t setup codecov using my github handle as I am not an eliza org member, could you sign in to codecov.io with your github handle and enable codecov on the eliza repo from the ai16z org. There are multiple steps that you would need to go through, we can setup a meeting where we can do that together, here is an example of the steps I am seeing when selecting Sifchain > sa-eliza repo: |
Sure, are you free now? @snobbee |
Seems like no, I will coordinate with you more on slack |
sure, will do in the call |
for context, @jkbrooks requested shawn (ai16z) to help with that task, waiting for his feedback |
@jkbrooks did you get any feedback from Shawn about that? |
@snobbee it's "Shaw" It's very late for him right now, but I will bump this with him tomorrow. |
FYI sounds like @jkbrooks will be able to be granted "admin" access so we will be able to move forward with this ticket. |
We did a pretty good job here, but now we need to make an announcement to the community and coordinate. Someone already disabled the test, and we aren't sure why. Our intention is that this is not blocking, we just have a target. We believe the current code coverage is around 30%. Our target for the repo is 70%. We need to agree with the community on what the target should be and also on what should happen as for blockers and identify what potential blockers may have existed. elizaOS@c9f27be#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR41 |
@snobbee please close after you revert elizaOS@c9f27be#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR37 assuming all tests work othewise please comment on any additional things to be addressed |
PR ready to review elizaOS#880 |
PR created elizaOS#1019 to generate coverage files for codecov cc @monilpat @jkbrooks |
Add codecov in order to get an automatic report of each new PR test coverage and set some goals to encourage community to improve their test coverage.
The text was updated successfully, but these errors were encountered: