Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation about deprotection settings when clicking the deprotect button. #1

Open
ShellyHerself opened this issue Sep 5, 2019 · 2 comments

Comments

@ShellyHerself
Copy link
Member

This should lower the required pre-existing knowledge for users, and avoid needing to reload the map if the deprotection settings were wrong.

@MosesofEgypt
Copy link
Contributor

How do you propose this confirmation works? The deprotection settings are spread across a couple tabs in the settings window, so it wouldn't be good enough to just bring up the settings window and ask "are these deprotection settings okay?".

@ShellyHerself
Copy link
Member Author

Hm, see that is something I didn't realize.

What I would say is give the user like a textbox that shows them what kind of changes to the tags they should expect because of what options. Let them click ok if they are fine, cancel if they are not. edit if they want to bring up the settings menu to change them a little.

Speaking of which, we should have some tooltips for those of those settings. Maybe we should have an issue for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants