feature: PBVE - auxillary engine temperature #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybentley
force-pushed
the
nmea0183-PBVE-temp
branch
from
68afb0e
to
aa29da0
Compare
|
Looks like solid work, at least in proving the accuracy! |
tkurki
reviewed
Feb 21, 2019
| const ALPHA = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'.split('') | ||
| E: { | ||
| path: 'propulsion.0.coolantTemperature', | ||
| meta: { |
There was a problem hiding this comment.
I don't think this will accomplish what you are after here. Check the full that results from this - does it have the meta in place that should be there?
We don't have a way to update meta information with a delta. @sbender9 was working on this at SignalK/signalk-server#481 but that stalled. This use case could be the time to resurrect that line of work.
|
Even if the meta stuff is off I am going to merge this, as the conversion itself works. For the meta values it would be useful to not send them all the time, only when they change. And as I commented earlier the downstream support for updating meta is not there yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added product code E, engine coolant temperature
Added the following meta for providing CruzPro gauge information:
Added conversion into signalk specified format (f->k, psi->pa)
Updated unit tests to verify all meta model values
Verified with @sk/instrumentPanel and CruzPro gauges (see attached photos)
Note: Temperature is off one degree due to latency between photo and screenshot. Numbers are identical in realtime.