Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR6J correction #2

Closed
Dr-Jamie-Brown opened this issue Aug 15, 2024 · 3 comments
Closed

GR6J correction #2

Dr-Jamie-Brown opened this issue Aug 15, 2024 · 3 comments
Assignees

Comments

@Dr-Jamie-Brown
Copy link

Very well done creating this working GR package for python.

I found a slight error in the GR6J.rs file whilst trying to compare hydrogr to the airgr R version. in line 116 the it should read exp_flow = x6*ar.exp(); and not exp_flow = x6/ar.exp(); . The issue creates extremely large flows when states[2]/x6 drops below -33 which in turn allows the exp_flow to become a extremely high. A simple error but has large modelling implications.
image

@SimonDelmas
Copy link
Owner

Thank you very much for your feedback. I am currently traveling, but I will correct this when I return.

@SimonDelmas SimonDelmas self-assigned this Aug 17, 2024
@SimonDelmas
Copy link
Owner

Fixed in version 1.2.1, thanks @Dr-Jamie-Brown !

@Dr-Jamie-Brown
Copy link
Author

Thanks @SimonDelmas Very much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants