You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Very well done creating this working GR package for python.
I found a slight error in the GR6J.rs file whilst trying to compare hydrogr to the airgr R version. in line 116 the it should read exp_flow = x6*ar.exp(); and not exp_flow = x6/ar.exp(); . The issue creates extremely large flows when states[2]/x6 drops below -33 which in turn allows the exp_flow to become a extremely high. A simple error but has large modelling implications.
The text was updated successfully, but these errors were encountered:
Very well done creating this working GR package for python.
I found a slight error in the GR6J.rs file whilst trying to compare hydrogr to the airgr R version. in line 116 the it should read exp_flow = x6*ar.exp(); and not exp_flow = x6/ar.exp(); . The issue creates extremely large flows when states[2]/x6 drops below -33 which in turn allows the exp_flow to become a extremely high. A simple error but has large modelling implications.
The text was updated successfully, but these errors were encountered: