STYLE: Prefer = default to explicitly trivial implementations

This check replaces default bodies of special member functions with = default;. The explicitly defaulted function declarations enable more opportunities in optimization, because the compiler might treat explicitly defaulted functions as trivial. Additionally, the C++11 use of = default more clearly expreses the intent for the special member functions.
SimonRit · Feb 17, 2020 · 3866646 · 3866646
1 parent 17541d4
commit 3866646
Show file tree

Hide file tree

Showing 34 changed files with 35 additions and 35 deletions.
diff --git a/applications/rtkprojectionmatrix/rtkprojectionmatrix.cxx b/applications/rtkprojectionmatrix/rtkprojectionmatrix.cxx
@@ -34,8 +34,8 @@ template <class TInput, class TCoordRepType, class TOutput = TCoordRepType>
 class StoreSparseMatrixSplatWeightMultiplication
 {
 public:
-  StoreSparseMatrixSplatWeightMultiplication(){};
-  ~StoreSparseMatrixSplatWeightMultiplication(){};
+  StoreSparseMatrixSplatWeightMultiplication()= default;;
+  ~StoreSparseMatrixSplatWeightMultiplication()= default;;
   bool
   operator!=(const StoreSparseMatrixSplatWeightMultiplication &) const
   {

diff --git a/include/rtkConjugateGradientOperator.hxx b/include/rtkConjugateGradientOperator.hxx
@@ -26,7 +26,7 @@ namespace rtk
 
 template <typename OutputImageType>
 ConjugateGradientOperator<OutputImageType>::ConjugateGradientOperator()
-{}
+= default;
 
 template <typename OutputImageType>
 void

diff --git a/include/rtkConstantImageSource.hxx b/include/rtkConstantImageSource.hxx
@@ -45,7 +45,7 @@ ConstantImageSource<TOutputImage>::ConstantImageSource()
 
 template <class TOutputImage>
 ConstantImageSource<TOutputImage>::~ConstantImageSource()
-{}
+= default;
 
 template <class TOutputImage>
 void

diff --git a/include/rtkCyclicDeformationImageFilter.h b/include/rtkCyclicDeformationImageFilter.h
@@ -81,7 +81,7 @@ class ITK_EXPORT CyclicDeformationImageFilter : public itk::ImageToImageFilter<T
   itkSetMacro(Frame, unsigned int);
 
 protected:
-  CyclicDeformationImageFilter() {}
+  CyclicDeformationImageFilter() = default;
   ~CyclicDeformationImageFilter() override = default;
 
   void

diff --git a/include/rtkDPExtractShroudSignalImageFilter.hxx b/include/rtkDPExtractShroudSignalImageFilter.hxx
@@ -28,7 +28,7 @@ namespace rtk
 
 template <class TInputPixel, class TOutputPixel>
 DPExtractShroudSignalImageFilter<TInputPixel, TOutputPixel>::DPExtractShroudSignalImageFilter()
-{}
+= default;
 
 template <class TInputPixel, class TOutputPixel>
 void

diff --git a/include/rtkDaubechiesWaveletsConvolutionImageFilter.hxx b/include/rtkDaubechiesWaveletsConvolutionImageFilter.hxx
@@ -37,7 +37,7 @@ DaubechiesWaveletsConvolutionImageFilter<TImage>::DaubechiesWaveletsConvolutionI
 
 template <typename TImage>
 DaubechiesWaveletsConvolutionImageFilter<TImage>::~DaubechiesWaveletsConvolutionImageFilter()
-{}
+= default;
 
 template <typename TImage>
 void

diff --git a/include/rtkDeconstructImageFilter.hxx b/include/rtkDeconstructImageFilter.hxx
@@ -28,7 +28,7 @@ namespace rtk
 // Default Constructor
 template <class TImage>
 DeconstructImageFilter<TImage>::DeconstructImageFilter()
-{}
+= default;
 
 /////////////////////////////////////////////////////////
 // PrintSelf()

diff --git a/include/rtkDisplacedDetectorForOffsetFieldOfViewImageFilter.hxx b/include/rtkDisplacedDetectorForOffsetFieldOfViewImageFilter.hxx
@@ -35,7 +35,7 @@ namespace rtk
 template <class TInputImage, class TOutputImage>
 DisplacedDetectorForOffsetFieldOfViewImageFilter<TInputImage,
                                                  TOutputImage>::DisplacedDetectorForOffsetFieldOfViewImageFilter()
-{}
+= default;
 
 /**
  * When the detector is displaced, one needs to zero pad the input data on the

diff --git a/include/rtkDisplacedDetectorImageFilter.hxx b/include/rtkDisplacedDetectorImageFilter.hxx
@@ -30,7 +30,7 @@ namespace rtk
 
 template <class TInputImage, class TOutputImage>
 DisplacedDetectorImageFilter<TInputImage, TOutputImage>::DisplacedDetectorImageFilter()
-{}
+= default;
 
 template <class TInputImage, class TOutputImage>
 void

diff --git a/include/rtkDrawConvexImageFilter.hxx b/include/rtkDrawConvexImageFilter.hxx
@@ -29,7 +29,7 @@ namespace rtk
 
 template <class TInputImage, class TOutputImage>
 DrawConvexImageFilter<TInputImage, TOutputImage>::DrawConvexImageFilter()
-{}
+= default;
 
 template <class TInputImage, class TOutputImage>
 void

diff --git a/include/rtkFDKWarpBackProjectionImageFilter.hxx b/include/rtkFDKWarpBackProjectionImageFilter.hxx
@@ -31,7 +31,7 @@ namespace rtk
 
 template <class TInputImage, class TOutputImage, class TDeformation>
 FDKWarpBackProjectionImageFilter<TInputImage, TOutputImage, TDeformation>::FDKWarpBackProjectionImageFilter()
-{}
+= default;
 
 template <class TInputImage, class TOutputImage, class TDeformation>
 void

diff --git a/include/rtkFFTRampImageFilter.hxx b/include/rtkFFTRampImageFilter.hxx
@@ -34,7 +34,7 @@ namespace rtk
 
 template <class TInputImage, class TOutputImage, class TFFTPrecision>
 FFTRampImageFilter<TInputImage, TOutputImage, TFFTPrecision>::FFTRampImageFilter()
-{}
+= default;
 
 template <class TInputImage, class TOutputImage, class TFFTPrecision>
 void

diff --git a/include/rtkFieldOfViewImageFilter.hxx b/include/rtkFieldOfViewImageFilter.hxx
@@ -36,7 +36,7 @@ namespace rtk
 
 template <class TInputImage, class TOutputImage>
 FieldOfViewImageFilter<TInputImage, TOutputImage>::FieldOfViewImageFilter()
-{}
+= default;
 
 template <class TInputImage, class TOutputImage>
 bool

diff --git a/include/rtkJosephBackProjectionImageFilter.hxx b/include/rtkJosephBackProjectionImageFilter.hxx
@@ -44,7 +44,7 @@ JosephBackProjectionImageFilter<TInputImage,
                                 TInterpolationWeightMultiplication,
                                 TSplatWeightMultiplication,
                                 TSumAlongRay>::JosephBackProjectionImageFilter()
-{}
+= default;
 
 template <class TInputImage,
           class TOutputImage,

diff --git a/include/rtkMultiplyByVectorImageFilter.hxx b/include/rtkMultiplyByVectorImageFilter.hxx
@@ -29,7 +29,7 @@ namespace rtk
 //
 template <class TInputImage>
 MultiplyByVectorImageFilter<TInputImage>::MultiplyByVectorImageFilter()
-{}
+= default;
 
 template <class TInputImage>
 void

diff --git a/include/rtkNesterovUpdateImageFilter.hxx b/include/rtkNesterovUpdateImageFilter.hxx
@@ -38,7 +38,7 @@ NesterovUpdateImageFilter<TImage>::NesterovUpdateImageFilter()
 
 template <typename TImage>
 NesterovUpdateImageFilter<TImage>::~NesterovUpdateImageFilter()
-{}
+= default;
 
 template <typename TImage>
 void

diff --git a/include/rtkOraLookupTableImageFilter.h b/include/rtkOraLookupTableImageFilter.h
@@ -89,7 +89,7 @@ class ITK_EXPORT OraLookupTableImageFilter
   }
 
 protected:
-  OraLookupTableImageFilter() {}
+  OraLookupTableImageFilter() = default;
   ~OraLookupTableImageFilter() override = default;
 
 private:

diff --git a/include/rtkPhaseReader.hxx b/include/rtkPhaseReader.hxx
@@ -25,7 +25,7 @@
 namespace rtk
 {
 
-PhaseReader::PhaseReader() {}
+PhaseReader::PhaseReader() = default;
 
 void
 PhaseReader::PrintSelf(std::ostream & os, itk::Indent indent) const

diff --git a/include/rtkPolynomialGainCorrectionImageFilter.hxx b/include/rtkPolynomialGainCorrectionImageFilter.hxx
@@ -30,7 +30,7 @@ namespace rtk
 
 template <class TInputImage, class TOutputImage>
 PolynomialGainCorrectionImageFilter<TInputImage, TOutputImage>::PolynomialGainCorrectionImageFilter()
-{}
+= default;
 
 template <class TInputImage, class TOutputImage>
 void

diff --git a/include/rtkRayQuadricIntersectionImageFilter.hxx b/include/rtkRayQuadricIntersectionImageFilter.hxx
@@ -31,7 +31,7 @@ namespace rtk
 
 template <class TInputImage, class TOutputImage>
 RayQuadricIntersectionImageFilter<TInputImage, TOutputImage>::RayQuadricIntersectionImageFilter()
-{}
+= default;
 
 template <class TInputImage, class TOutputImage>
 void

diff --git a/include/rtkReconstructImageFilter.hxx b/include/rtkReconstructImageFilter.hxx
@@ -29,7 +29,7 @@ namespace rtk
 // Default Constructor
 template <class TImage>
 ReconstructImageFilter<TImage>::ReconstructImageFilter()
-{}
+= default;
 
 
 /////////////////////////////////////////////////////////

diff --git a/include/rtkReg1DExtractShroudSignalImageFilter.hxx b/include/rtkReg1DExtractShroudSignalImageFilter.hxx
@@ -34,7 +34,7 @@ namespace rtk
 
 template <class TInputPixel, class TOutputPixel>
 Reg1DExtractShroudSignalImageFilter<TInputPixel, TOutputPixel>::Reg1DExtractShroudSignalImageFilter()
-{}
+= default;
 
 template <class TInputPixel, class TOutputPixel>
 void

diff --git a/include/rtkSelectOneProjectionPerCycleImageFilter.hxx b/include/rtkSelectOneProjectionPerCycleImageFilter.hxx
@@ -26,7 +26,7 @@ namespace rtk
 
 template <typename ProjectionStackType>
 SelectOneProjectionPerCycleImageFilter<ProjectionStackType>::SelectOneProjectionPerCycleImageFilter()
-{}
+= default;
 
 template <typename ProjectionStackType>
 void

diff --git a/include/rtkVarianObiRawImageFilter.hxx b/include/rtkVarianObiRawImageFilter.hxx
@@ -27,7 +27,7 @@ namespace rtk
 
 template <typename TInputImage, typename TOutputImage>
 VarianObiRawImageFilter<TInputImage, TOutputImage>::VarianObiRawImageFilter()
-{}
+= default;
 
 template <typename TInputImage, typename TOutputImage>
 void

diff --git a/include/rtkZengBackProjectionImageFilter.h b/include/rtkZengBackProjectionImageFilter.h
@@ -123,7 +123,7 @@ class ITK_EXPORT ZengBackProjectionImageFilter : public BackProjectionImageFilte
 
 protected:
   ZengBackProjectionImageFilter();
-  ~ZengBackProjectionImageFilter() ITK_OVERRIDE {}
+  ~ZengBackProjectionImageFilter() ITK_OVERRIDE = default;
 
   /** Apply changes to the input image requested region. */
   void

diff --git a/include/rtkZengForwardProjectionImageFilter.h b/include/rtkZengForwardProjectionImageFilter.h
@@ -115,7 +115,7 @@ class ITK_EXPORT ZengForwardProjectionImageFilter : public ForwardProjectionImag
 
 protected:
   ZengForwardProjectionImageFilter();
-  ~ZengForwardProjectionImageFilter() ITK_OVERRIDE {}
+  ~ZengForwardProjectionImageFilter() ITK_OVERRIDE = default;
 
   void
   GenerateInputRequestedRegion() ITK_OVERRIDE;

diff --git a/src/rtkConvexShape.cxx b/src/rtkConvexShape.cxx
@@ -21,7 +21,7 @@
 namespace rtk
 {
 
-ConvexShape ::ConvexShape() {}
+ConvexShape ::ConvexShape() = default;
 
 bool
 ConvexShape ::IsInside(const PointType & /*point*/) const

diff --git a/src/rtkDigisensGeometryReader.cxx b/src/rtkDigisensGeometryReader.cxx
@@ -23,7 +23,7 @@
 #include <itkVersor.h>
 #include <itkCenteredEuler3DTransform.h>
 
-rtk::DigisensGeometryReader ::DigisensGeometryReader() {}
+rtk::DigisensGeometryReader ::DigisensGeometryReader() = default;
 
 void
 rtk::DigisensGeometryReader ::GenerateData()

diff --git a/src/rtkIntersectionOfConvexShapes.cxx b/src/rtkIntersectionOfConvexShapes.cxx
@@ -23,7 +23,7 @@
 namespace rtk
 {
 
-IntersectionOfConvexShapes ::IntersectionOfConvexShapes() {}
+IntersectionOfConvexShapes ::IntersectionOfConvexShapes() = default;
 
 void
 IntersectionOfConvexShapes ::SetConvexShapes(const ConvexShapeVector & _arg)

diff --git a/src/rtkQuadricShape.cxx b/src/rtkQuadricShape.cxx
@@ -21,7 +21,7 @@
 namespace rtk
 {
 
-QuadricShape ::QuadricShape() {}
+QuadricShape ::QuadricShape() = default;
 
 bool
 QuadricShape ::IsInside(const PointType & point) const

diff --git a/src/rtkReg23ProjectionGeometry.cxx b/src/rtkReg23ProjectionGeometry.cxx
@@ -22,7 +22,7 @@ rtk::Reg23ProjectionGeometry::Reg23ProjectionGeometry()
   : rtk::ThreeDCircularProjectionGeometry()
 {}
 
-rtk::Reg23ProjectionGeometry::~Reg23ProjectionGeometry() {}
+rtk::Reg23ProjectionGeometry::~Reg23ProjectionGeometry() = default;
 
 bool
 rtk::Reg23ProjectionGeometry::AddReg23Projection(const PointType &  sourcePosition,

diff --git a/src/rtkThreeDCircularProjectionGeometry.cxx b/src/rtkThreeDCircularProjectionGeometry.cxx
@@ -27,7 +27,7 @@
 #include <itkCenteredEuler3DTransform.h>
 #include <itkEuler3DTransform.h>
 
-rtk::ThreeDCircularProjectionGeometry::ThreeDCircularProjectionGeometry() {}
+rtk::ThreeDCircularProjectionGeometry::ThreeDCircularProjectionGeometry() = default;
 
 double
 rtk::ThreeDCircularProjectionGeometry::ConvertAngleBetween0And360Degrees(const double a)

diff --git a/src/rtkWatcherForResourceProbe.cxx b/src/rtkWatcherForResourceProbe.cxx
@@ -165,6 +165,6 @@ WatcherForResourceProbe ::operator=(const WatcherForResourceProbe & watch)
   return *this;
 }
 
-WatcherForResourceProbe ::~WatcherForResourceProbe() {}
+WatcherForResourceProbe ::~WatcherForResourceProbe() = default;
 
 } // namespace rtk
diff --git a/test/rtkargsinfomanagertest.cxx b/test/rtkargsinfomanagertest.cxx
@@ -7,7 +7,7 @@ class args_info_test
 public:
   int testVar{ true };
   int verbose_flag{ 0 };
-  args_info_test() {}
+  args_info_test() = default;
 };
 
 class cleanup_functor