Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3 support #10

Open
samuelallan72 opened this issue Aug 28, 2018 · 2 comments
Open

Add python3 support #10

samuelallan72 opened this issue Aug 28, 2018 · 2 comments

Comments

@samuelallan72
Copy link

This library is not compatible with python3. Discovered this while beginning to port sncli to the simperium api.

Would there be any interest from Simperium to add python 3 support? With the current setup it could require a fair bit of work to support both with the current setup - perhaps it would be worth having a second repo simperium-python3 or similar?

Porting would involve:

  • updating the syntax
  • moving to the new urllib (it changed a lot between 2 and 3); perhaps consider using the requests library instead?
  • taking into account differences in string/bytes handling
@roundhill
Copy link
Contributor

roundhill commented Aug 28, 2018

I think we'd be interested in this, but I'm afraid we don't have any resources on our side at the moment to make it happen. I did notice this PR from a while back: #7.

I haven't tested that, but maybe could be a good start?

@samuelallan72
Copy link
Author

For reference, these days I maintain a python 3 port at https://sr.ht/~swalladge/python-simperium3/ .

According to @eshurakov :

We use python simperium library in some internal projects that are hard to update to python3 at the moment. To avoid accidental breakage I think it's better to keep python3 implementation as a separate project / library. At least for now :-)

Please let me know if/when you're interested in updating this to python3 or taking over maintainership of the separate python3 port; I'm very happy to work on contributing this back upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants