Diamond is added to forge:tools/diamond tag defined by CoFH Core

[andriihorpenko]

Mod Name

CoFH Core

Mod Homepage

https://www.curseforge.com/minecraft/mc-mods/cofh-core

Minecraft version

1.20.1

Describe the bug

Connector mistakenly adds Diamond item to the forge:tools/diamond tag defined by CoFH Core

Steps to reproduce

Note before reproduction

This effect can be achieved in approx 5/10 server restarts. The reason is unknown to me, but the bug does not happen consistently, though quite frequently.

Steps

1. Install Sinytra Connector and CoFH Core (here is the tag definition)
2. View tags of the vanilla's Diamond item. In approx 5/10 cases this item will have forge:tools/diamond tag.

Debugger steps

I've done some debugging, hopefully this will be useful due to the inconsistent nature of the bug.

1. Encountering c:diamonds tag

org.sinytra.connector.mod.compat.TagConverter#postProcessTags:42

2. Looping through COMMON_GROUP_PREFIXES (which includes "gems" and "tools")

org.sinytra.connector.mod.compat.TagConverter#getNormalizedTagName:83

3. Connector normalizes the tag to forge:tools/diamond

org.sinytra.connector.mod.compat.TagConverter#getNormalizedTagName:94

4. Connector adds invalid TagEntry

org.sinytra.connector.mod.compat.TagConverter#postProcessTags:53

Logs

https://gist.github.com/andriihorpenko/3fb6a1c3ad27139e946807a9cae1db12

Additional context

No response