Add a resolveModuleId and resolveModuleImport callback to options. #80
Conversation
|
Thanks @ritzingerp . I think this looks fine. Will let it sit a little longer in case anyone else wants to review. Will land it for 2.1.0. |
|
@ritzingerp resolving #90 has introduced a small conflict here... please rebase and then I'll land this. Also, if you have time, please also add a PR to update the README. Thanks! |
…tePen#80) With these callbacks callers can provide custom logic how the identifiers of declared and imported modules will be written into the generated d.ts
ritzingerp
changed the title
|
The rebase is done. I have extended this pull request to not only be able to customize module ids in I have also created a unit test case. |
There was a problem hiding this comment.
Other than a couple of minor indentation nits, this looks ready. Thanks for the effort @ritzingerp !
| @@ -56,11 +74,11 @@ function getError(diagnostics: ts.Diagnostic[]) { | |||
| // the tsconfig.json don't; the messageText is enough to diagnose in those | |||
| // cases. | |||
| if (diagnostic.file) { | |||
| const position = diagnostic.file.getLineAndCharacterOfPosition(diagnostic.start); | |||
| const position = diagnostic.file.getLineAndCharacterOfPosition(diagnostic.start); | |||
There was a problem hiding this comment.
Looks like the indentation here is off by one?
| message += | ||
| `\n${diagnostic.file.fileName}(${position.line + 1},${position.character + 1}): ` + | ||
| `error TS${diagnostic.code}: ${diagnostic.messageText}`; | ||
| message += |
There was a problem hiding this comment.
indentation change unintentional?
…tePen#80) With these callbacks callers can provide custom logic how the identifiers of declared and imported modules will be written into the generated d.ts
|
I have fixed the indentation, it was not intended. |
|
Originally this pull request introduced a breaking change. For input file import { x } from 'x';the following was generated before the pull request: declare module 'name/some/module' {
import { x } from 'x';
}and originally with the pull request: declare module 'name/some/module' {
import { x } from 'name/x'; // 'name/' prepended to import, only if there was no declare module 'x' in input
}The latest commit for this pull request reverses this behavior, and does not introduce a breaking change. This might be related to #94, but I think this pull request should not include a breaking change. |
| @@ -0,0 +1,5 @@ | |||
| export class NonRel { | |||
There was a problem hiding this comment.
I'm going to be picky here and say that we should call this NonRelative throughout, given that Rel can have multiple meanings.
|
Agree, renamed to NonRelative. |
|
Thanks @ritzingerp ! |
With this callback callers can provide a custom logic how the identifiers of referenced modules will be written into the generated d.ts