Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rendering hints for <noscript> elements #251

Closed
kasperisager opened this issue Jun 8, 2020 · 1 comment · Fixed by #260
Closed

Add rendering hints for <noscript> elements #251

kasperisager opened this issue Jun 8, 2020 · 1 comment · Fixed by #260
Assignees
@kasperisager

Comments

@kasperisager
Copy link
Contributor

kasperisager commented Jun 8, 2020 •
edited
Loading

The user agent styles are currently lacking definitions for <noscript> elements which means that Alfa considers these visible when it shouldn't. See https://html.spec.whatwg.org/multipage/rendering.html#hidden-elements.
@kasperisager kasperisager self-assigned this Jun 10, 2020
@kasperisager kasperisager mentioned this issue Jun 10, 2020
Merged
@kasperisager
Copy link
Contributor Author

Once #259 has been merged, I'll implement matching of the scripting feature and then add rendering hints for the <noscript> element.

@kasperisager kasperisager mentioned this issue Jun 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasperisager kasperisager

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add user agent styles for <noscript> element Siteimprove/alfa
1 participant
@kasperisager