You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The last time an ADR was added was in March, 2019: 3b4329a. Since then, several additional architecture decisions have been made, notably as part of #165. #172 was opened as a reminder to write ADRs for that particular set of changes, but this has not yet manifested due to other priorities. I'd like for us to sit down at some point and come up with a list of decisions that we feel are important to document. Not just for our own sake, but for the sake of future colleagues and collaborators who wish to understand the fundamental decisions that brought Alfa to where it's currently at, which is the whole point of the ADRs.
Off the top of my head, the following things come to mind:
The introduction of the Option<T> type in The Great Refactoring™️ #165. Why not T | null or T | undefined combined with the optional chaining operator, ?., and the nullish coalescing operator, ???
The introduction of the trilean logic in Three valued logic #174. Why was boolean logic insufficient?
The introduction of the @siteimprove/alfa-command package in Rewrite the CLI internals #265. Why not any of the countless other CLI libraries for Node.js?
(extended) diagnostics
enriched questions: rhetorical, optional, with diagnostic
The text was updated successfully, but these errors were encountered:
The last time an ADR was added was in March, 2019: 3b4329a. Since then, several additional architecture decisions have been made, notably as part of #165. #172 was opened as a reminder to write ADRs for that particular set of changes, but this has not yet manifested due to other priorities. I'd like for us to sit down at some point and come up with a list of decisions that we feel are important to document. Not just for our own sake, but for the sake of future colleagues and collaborators who wish to understand the fundamental decisions that brought Alfa to where it's currently at, which is the whole point of the ADRs.
Off the top of my head, the following things come to mind:
Option<T>
type in The Great Refactoring™️ #165. Why notT | null
orT | undefined
combined with the optional chaining operator,?.
, and the nullish coalescing operator,??
?Future<T>
type in The Great Refactoring™️ #165. Why notPromise<T>
?Result<T, E>
type in The Great Refactoring™️ #165. Why not exceptions?@siteimprove/alfa-command
package in Rewrite the CLI internals #265. Why not any of the countless other CLI libraries for Node.js?The text was updated successfully, but these errors were encountered: