Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow implementing custom brush types #149

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #20 allowing custom brushes inheriting BrushApplicator

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc.1 milestone Jul 7, 2021
@JimBobSquarePants JimBobSquarePants requested a review from a team July 7, 2021 13:45
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #149 (f4fdab3) into master (423bf06) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   69.35%   69.35%           
=======================================
  Files          89       89           
  Lines        5142     5142           
  Branches     1051     1051           
=======================================
  Hits         3566     3566           
  Misses       1359     1359           
  Partials      217      217           
Flag Coverage Δ
unittests 69.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/ImageSharp.Drawing/Processing/BrushApplicator.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 423bf06...f4fdab3. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimBobSquarePants JimBobSquarePants merged commit a1ca308 into master Jul 8, 2021
@JimBobSquarePants JimBobSquarePants deleted the js/custom-brushes branch July 8, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow implementing custom brush types
2 participants