Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ImageBrush source region constructor. #306

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

See #305 The public constructor is required to selecting the source region providing the ability to negative offset and image.

@JimBobSquarePants JimBobSquarePants added enhancement New feature or request API labels Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2316146) 80% compared to head (3ee51ef) 80%.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #306   +/-   ##
===================================
  Coverage    80%    80%           
===================================
  Files        97     97           
  Lines      4946   4946           
  Branches    884    884           
===================================
  Hits       3997   3997           
  Misses      754    754           
  Partials    195    195           
Flag Coverage Δ
unittests 80% <100%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimBobSquarePants JimBobSquarePants merged commit ec146c9 into main Dec 6, 2023
23 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/fix-305 branch December 6, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants