-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does Jpeg format need comment marker support? #2067
Comments
any updates on this? I was looking to use it from ImageSharp (as I do use it for bunch of other stuff) |
No changes, happy to accept contributions though! |
I think this place is better for a small guide than that discussion @prabhavmehra. First of all, COM marker is already hooked up in the decoding loop here The only thing left to do is to actually parse given stream which is skipped right now using this line: And the final question is where to store parsed results. Results should be saved into JpegMetadata class. AFAIR we decided to implement it as an The only thing that bothers me is what should we do if there are no COM markers in given JPEG, leave new property as null or an empty ICollection... |
How about a nullable |
I would like to add in here that I feel reading I feel it needs to be opt-in for a couple of reasons.
|
Jpeg can have many COM markers so either @tocsoft extra configuration seems fair. |
Mostly API consistency, we use that type for color pallet pallet metadata. |
Fair enough, I have nothing against nullable |
This was added in #2641 |
Discussed in #2061
Originally posted by br3aker March 13, 2022
Current jpeg implementation lacks of COM marker support, does it need to support it? Should be easy to implement as this marker is just an array of bytes - itu spec leaves 'interpretation to the application', decoding API should not try to decode it as it can be anything from literal byte array to some weird text encoding.
So it can be a 'good first issue' or I can work on it a bit later.
The text was updated successfully, but these errors were encountered: