-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement discontiguous buffer handling #1109
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
=========================================
+ Coverage 82.04% 82.15% +0.1%
=========================================
Files 680 686 +6
Lines 28562 29048 +486
Branches 3238 3308 +70
=========================================
+ Hits 23434 23864 +430
- Misses 4453 4485 +32
- Partials 675 699 +24
Continue to review full report at Codecov.
|
Looks like I managed to fix everything, removed the WIP tag, ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work!
All looks good to me, just spotted a possible optimization opportunity in RowOctet<T>
I like that we can implement any enhancements to individual codecs in the future.
Prerequisites
Description
Marked as WIPbecause processors and codecs need adaption, but the core logic is ready to review!MemorySource<T>
has been replaced withMemoryGroup<T>
, which is a list of uniformly sized buffers (IMemoryOwner<T>
andMemory<T>
)MemoryGroupExtensions
eg..CopyTo()
MemoryGroupView<T>
is an indirection to expose these memory buffers in a safe way, see docs and comments for more infoAdvancedMemoryExtensions
have been changed to reflect the new memory model,.GetPixelSpan<T>()
has been made obsoletebuffer2d.GetSpan<T>()
--->buffer2d.GetSingleSpan<T>()
, temporarily marked[Obsolete]
to guide refactorTODO
We should no longer process
Buffer2D
as a single span (except of a few special cases like resize KernelMap). Guidance: go through all[Obsolote]
warnings.Resolves #898, Fixes #805