Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All items in inventory expression doesn't return the correct value in loops #2340

Closed
LenjoyOfficial opened this issue Aug 5, 2019 · 7 comments
Assignees
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@LenjoyOfficial
Copy link

Description

When I want to loop all the items in a chest inventory, and printing the values for debug,
it says the slot instead of the items.

Steps to Reproduce

Type the command /test:

command test:
	trigger:
		open a chest inventory named "" with 2 rows to player
		set slot 0 of player's current inventory to dirt named "&aDirt"
		loop all items in player's current inventory:
			send "%loop-value%"

See the chat

Expected Behavior

Prints out this in the chat: "dirt named "&aDirt""

Errors / Screenshots

image

Server Information

  • Server version/platform: CraftBukkit version git-Spigot-1a3504a-84f3da3 (MC: 1.13.2)
  • Skript version: v2.4-beta5
@LenjoyOfficial LenjoyOfficial changed the title All items in inventory effect doesn't work All items in inventory expression doesn't work Aug 5, 2019
@TUCAOEVER
Copy link
Contributor

loop-item instead of loop-value?

@LenjoyOfficial
Copy link
Author

it prints the same

@bensku
Copy link
Member

bensku commented Aug 5, 2019

They can be compared againt items. Still, this is not intentional.

@bensku bensku added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Aug 5, 2019
@LenjoyOfficial
Copy link
Author

huh thanks i thought i did a mistake

@Runakai1
Copy link

Runakai1 commented Aug 6, 2019

The title is a bit misleading since %all items in player's [current] inventory% still works

@LenjoyOfficial
Copy link
Author

ok but nobody will read only a title and test it as it is in the title

@oseuseu
Copy link

oseuseu commented Aug 8, 2019

1 of loop-value

@LenjoyOfficial LenjoyOfficial changed the title All items in inventory expression doesn't work All items in inventory expression doesn't return the correct value in loops Sep 3, 2019
@APickledWalrus APickledWalrus self-assigned this Oct 4, 2020
@ShaneBeee ShaneBeee added the completed The issue has been fully resolved and the change will be in the next Skript update. label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

7 participants