Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item with lore expression thows CCE when used with variables #2347

Closed
bloggy opened this issue Aug 6, 2019 · 14 comments
Closed

Item with lore expression thows CCE when used with variables #2347

bloggy opened this issue Aug 6, 2019 · 14 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@bloggy
Copy link

bloggy commented Aug 6, 2019

Another issue:

Code:

command /testi [<text>]:
	trigger:
		open virtual chest inventory with 3 rows named "test" to player
		set {_i} to 0
		set {_p} to player
		set {_item} to APPLE
		set {_name} to {_item}'s name
		add "test1" to {_lore::*}
		add "test2" to {_lore::*}
		loop 3 times:
			make a gui slot {_i} of {_p} with {_item} with name {_itemname} with lore {_lore::*} to run function Guma_BuySlot({_id},loop-number - 1,{_p})
			add 1 to {_i}

Error:
https://pastebin.com/XhaKSsPR

@bloggy
Copy link
Author

bloggy commented Aug 6, 2019

replacing the {_item} in the make a gui slot effect with APPLE makes the code work.

@Runakai1
Copy link

Runakai1 commented Aug 6, 2019

This is not a skript issue. It's tuske

@bloggy
Copy link
Author

bloggy commented Aug 6, 2019

Sure? How can I make the same with Skript?

@Whimsyturtle
Copy link
Member

Whimsyturtle commented Aug 7, 2019

@bloggy If it’s a Tuske bug report it to their author, not here.

@bloggy
Copy link
Author

bloggy commented Aug 7, 2019

I don't know if it is a Tuske bug. And there is no active developer of Tuske I think. So no more GUIs in skript? or is @Pikachu920 maintaining it now? I can not find any further information, maybe Pikachu920 can say something?

Somebody wrote this interesting post regarding this bug in the skunity forums:
https://forums.skunity.com/threads/tuske-is-dead-no-more-gui-stuff.9669/#post-42361

@Runakai1
Copy link

Runakai1 commented Aug 7, 2019

There are guis in vanilla skript. The Inventory name expression is just broken. Use skript mirror for that and everything should work fine. (Event.getView().getTitle() is "inventory name")
There is a tutorial about vanilla guis on the forum tutorial page (skunity)

@bloggy
Copy link
Author

bloggy commented Aug 7, 2019

There are guis in vanilla skript. The Inventory name expression is just broken. Use skript mirror for that and everything should work fine. (Event.getView().getTitle() is "inventory name")
There is a tutorial about vanilla guis on the forum tutorial page (skunity)

I should wait for the devs to answer here because changing all my scripts would take me days ...

@Runakai1
Copy link

Runakai1 commented Aug 7, 2019

Imo you should just spend your time learning vanilla guis. Depending on an add-on that's most likely going to be abandoned or already is is not good

@Blueyescat
Copy link
Contributor

Blueyescat commented Aug 7, 2019

You didn't actually show the error of the first code.
The second error is related to Skript.

also why use skellett to open the inventory

@bloggy
Copy link
Author

bloggy commented Aug 7, 2019

You didn't actually show the error of the first code.
The second error is related to Skript.

also why use skellett to open the inventory

Oh yeah I noticed it. I think the first error was fixed and not a Skript bug. I removed it for now. But the second issue still persists. I will no longer use skellett to open inventory (I use skript's feature now)

@FranKusmiruk FranKusmiruk added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Aug 7, 2019
@FranKusmiruk FranKusmiruk changed the title GUIs are bugged Item with lore expression thows CCE when used with variables Aug 7, 2019
@bloggy
Copy link
Author

bloggy commented Aug 21, 2019

Do you think you can fix this asap? I can not do anything because of GUIs not working and there has been no new release for more than 2 weeks.

@Whimsyturtle
Copy link
Member

Whimsyturtle commented Sep 4, 2019

Did a quick test using variables:

  • Name and Lore are set: No CCE
  • Name is set, Lore isn't set: No CCE
  • Name isn't set, Lore is set: CCE thrown
  • Name and Lore aren't set: CCE thrown

Then, without the name and lore variables being set,

  • Lore removed: No CCE
  • Name removed: No CCE
  • Lore and Name are removed: No CCE
  • Lore and Name remain: CCE thrown

Doing the test again with direct value reference instead of a variable:

  • Name and Lore are set: No CCE
  • Name is set, Lore isn't set: No CCE
  • Name isn't set, Lore is set: No CCE
  • Name and Lore aren't set: No CCE

Seems like this is only thrown when the name isn't set using variables, but only occurs when name is used in conjunction with lore (directly referenced / set in a variable / not set in a variable)

Testing further:

  • Name is variable, and is not set, lore is directly referenced: CCE thrown
  • Name is variable, and is not set (no use of lore): No CCE
  • Name is directly referenced, lore is variable and is not set: No CCE
  • Name is directly referenced (no use of lore): No CCE

@ShaneBeee
Copy link
Contributor

Just wanted to check in on this issue.
The last comment was back in September, 6 months ago, we've had several releases since then, just wanted to check in and see if this issue is still present.

@APickledWalrus APickledWalrus added the needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. label Oct 23, 2020
@TPGamesNL
Copy link
Member

Can confirm with

set {_item} to apple
add "test" to {_lore::*}
set {_x} to {_item} with name {_NONE} with lore {_lore::*}

or set {_x} to {_item} with name {_NONE} with lore {_NONE::*} for the last line
error: https://pastebin.com/BVVhD5Ed

@TPGamesNL TPGamesNL removed the needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. label Mar 12, 2021
@TPGamesNL TPGamesNL added the PR available Issues which have a yet-to-be merged PR resolving it label Mar 23, 2021
@APickledWalrus APickledWalrus added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

8 participants