Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Outdated" docs? #2705

Closed
MaPaJe opened this issue Dec 18, 2019 · 4 comments
Closed

"Outdated" docs? #2705

MaPaJe opened this issue Dec 18, 2019 · 4 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. documentation Related to Skript's official documentation. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@MaPaJe
Copy link

MaPaJe commented Dec 18, 2019

Description

Not able to get past information of sneaking

Steps to Reproduce

on sneak toggle:
player was sneaking
push the player upwards at speed 0.5

Expected Behavior

I could get past tense of sneak

Errors / Screenshots

https://gyazo.com/e5fa37b10df1d8ed1b44431b73c801d1
https://skriptlang.github.io/Skript/events.html#sneak_toggle

Server Information

  • Server version/platform: 1.15.1 & 1.14.4
  • Skript version: 2.4

Additional Context

@APickledWalrus
Copy link
Member

Being able to use “was sneaking” would be nice. For now, use “is/is not sneaking” to determine this.

@MaPaJe
Copy link
Author

MaPaJe commented Dec 18, 2019

I need to use it together with "on advancement open:" which can be accessed with "L" but is sneaking will always return "False"

@ShaneBeee
Copy link
Contributor

This isn't a docs issue, this is an issue with past/future event-values, which has already been reported.

Duplicate of #671

@ShaneBeee ShaneBeee added the duplicate For bugs or requests that have already been made and are currently open. label Dec 22, 2019
@TheLimeGlass
Copy link
Collaborator

TheLimeGlass commented Jul 16, 2020

This issue actually isn't related to #671

The syntax just isn't a thing. TimeStates only work on expressions and event-values, not conditions.

sneaking is not a literal, expression or event-value, and you can't get a past state of a player in the sneak event from the CondIsSneaking.

What would be cool is creating time state conditions just like expressions though.

@ShaneBeee The documentation states player was sneaking so this is an actual issue. https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/skript/events/SimpleEvents.java#L315

https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/skript/conditions/CondCompare.java#L74-L81

Njol explains this here https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/skript/lang/Expression.java#L187-L188 but yet he wrote that documentation example lol

I might make a time state condition so this syntax will actually work.

@APickledWalrus APickledWalrus added documentation Related to Skript's official documentation. and removed duplicate For bugs or requests that have already been made and are currently open. labels Jul 16, 2020
@APickledWalrus APickledWalrus added the priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). label Jul 16, 2020
@TPGamesNL TPGamesNL added the PR available Issues which have a yet-to-be merged PR resolving it label Jul 30, 2021
@APickledWalrus APickledWalrus added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. documentation Related to Skript's official documentation. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

5 participants