Support for stored enchantments of enchanted books

[dkbay]

Description

Normally minecraft enchantsments in 1.15 are stored like so.

{id: "minecraft:enchanted_book", Count: 1b, tag: {StoredEnchantments: [{lvl: 1s, id: "minecraft:mending"}]}

But when I use Skript to give me a mending book using the following script

give player enchanted book of mending

It gives me a book that looks like this and there for doesn't work as a mending book...

{id: "minecraft:enchanted_book", Count: 1b, tag: {Enchantments: [{lvl: 1s, id: "minecraft:mending"}]}

Steps to Reproduce

Run the following script and try to use the book in an anvil you can also compare it to a normal mending book (They have different name colors too...)

command /mending:
	description: Get a mending book
	
	trigger:
		give player enchanted book of mending

Expected Behavior

Enchantments should be stored as "StoredEnchantments" instead of "Enchantments"

Errors / Screenshots

Vanilla mending book:

Skript mending book:

Server Information

• Server version/platform: Paper 143 (1.15.2)
• Skript version: 2.4.1

[Laukage]

i can confirm this.

[ShaneBeee]

This isn't a bug, this is just the fact that Skript doesn't have an expression for stored enchantments on books.

Ill mark this as a feature request. Hopefully we can get an expression for this in the future.

[Anarchick]

if it can help you:

function AddStoredEnchants(item: item, enchantments: enchantment types, force: boolean) :: item:
    set {_meta} to {_item}.getItemMeta()
    loop {_enchantments::*}:
        set {_ench} to loop-value
        set {_type} to {_ench}.getType()
        set {_level} to {_ench}.getLevel()
        {_meta}.addStoredEnchant({_type}, {_level} and {_force})
    {_item}.setItemMeta({_meta})
    return {_item}

function GetStoredEnchants(item: item) :: enchantment types:
    set {_meta} to {_item}.getItemMeta()
    set {_ench} to {_meta}.getStoredEnchants()
    set {_keys::*} to ...{_ench}.keySet()
    set {_values::*} to ...{_ench}.values()
    loop {_keys::*}:
        set {_enchantmentType} to "%loop-value% %{_values::%loop-index%}%" parsed as enchantment type
        add {_enchantmentType} to {_return::*}
    return {_return::*}

function RemoveStoredEnchants(item: item, enchantments: enchantments) :: item:
    set {_meta} to {_item}.getItemMeta()
    loop {_enchantments::*}:
        set {_enchantment} to loop-value
        {_meta}.removeStoredEnchant({_enchantment})
    {_item}.setItemMeta({_meta})
    return {_item}```

[ShaneBeee]

I forgot to add, until this is added directly to Skript, you can use what Anarchick showed above (which requires Skript-mirror), or I have also added it to SkBee https://skripthub.net/docs/?id=4071

[TPGamesNL]

Same goes for CondIsEnchanted, and probably more stuff

[xartuu]

Skript 2.8.2 same issue