Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Alphanumeric Username causing TPS to drop very badly #3742

Closed
not-3than opened this issue Feb 8, 2021 · 3 comments
Closed

Non-Alphanumeric Username causing TPS to drop very badly #3742

not-3than opened this issue Feb 8, 2021 · 3 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@not-3than
Copy link

Description

When Skript tries to get the UUID of an Offline player with a weird symbol, it causes an error, and if a player spams that command, such as /stats ✴acbsuq14☆, it makes the TPS drop super badly.

Steps to Reproduce

It's some kind of hacked client glitch, not sure which one. Whenever I try to spam the command, it doesn't happen. But one particular person keeps using a VPN to join with alts and spam different variations of that command.

Expected Behavior

It shouldn't cause the TPS to drop exponentially.

Errors / Screenshots

https://pastebin.com/HQPZzWmN

http://prntscr.com/yolhpw

Server Information

  • Server version/platform: git-Paper-"b89788a" MC 1.16.5 (Minehut)
  • Skript version: 2.5.3-MH (Minehut's custom fork of Skript)

Additional Context

@TheDGOfficial
Copy link
Contributor

TheDGOfficial commented Feb 8, 2021 via email

@WeeskyBDW
Copy link

Minecraft protocol dont block usernames with symbols ? Or non-alphanetic usernames

@TPGamesNL
Copy link
Member

It only allows a-zA-Z0-9_, but Skript uses the regex \S+ (and a length check), which allows for way more characters: https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/skript/classes/data/BukkitClasses.java#L853

@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Feb 20, 2021
@Whimsyturtle Whimsyturtle added the completed The issue has been fully resolved and the change will be in the next Skript update. label Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

6 participants