Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default behaviour of the log commands config option #3855

Closed
Misio12320 opened this issue Mar 26, 2021 · 3 comments
Closed

Change default behaviour of the log commands config option #3855

Misio12320 opened this issue Mar 26, 2021 · 3 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@Misio12320
Copy link

I would like to see on my server not log some useless new command.
Feel free to add:

command test:
    log command: false
    trigger:
        broadcast "%player% executed command"

it should not send to console player [UUID of player]: /command

@TPGamesNL
Copy link
Member

There's a config option for this:

log player commands: true
# Whether Skript should log the usage of custom commands.
# They will be logged as [INFORMATION] in this format: '<player>: /<command> <arguments>'

Is there any specific reason you want to have this per command?

@TPGamesNL TPGamesNL added the waiting for reply The report needs a response from the reporter to determine course of action. label Mar 26, 2021
@Misio12320
Copy link
Author

Misio12320 commented Mar 26, 2021

Is there any specific reason you want to have this per command?

Yes. The console spam me some useless messages when I want to try change something and its annoying and consume memory. My useful commands on server should log and useless not

There's a config option for this:

Weird. But it logs every command and wrongly (may only for me) in format this what is said in issue. I mean per command log, not every.

Would be nice to see also "log format:" and "log location: console|player|specific file"

@TPGamesNL
Copy link
Member

IMO this config option should be disabled by default, since servers already default to logging command usage.
Besides that, if you have important commands you want logged and you disabled logging of all server commands, you could always add a single line of code to the start of your command trigger to log it.

@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). and removed waiting for reply The report needs a response from the reporter to determine course of action. labels Mar 26, 2021
@FranKusmiruk FranKusmiruk changed the title No log command. Change default behaviour of the log commands config option Mar 26, 2021
@FranKusmiruk FranKusmiruk added the good first issue An issue that would be good for a first-time contributor to make a PR for label Mar 26, 2021
@FranKusmiruk FranKusmiruk added completed The issue has been fully resolved and the change will be in the next Skript update. and removed good first issue An issue that would be good for a first-time contributor to make a PR for labels May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

4 participants