Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when sending a message to a player and console with same effect #3863

Closed
AzonFR opened this issue Mar 27, 2021 · 1 comment
Closed
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@AzonFR
Copy link

AzonFR commented Mar 27, 2021

Description

The send effect doesn't work when we send a message to player[s] and console
But it work when player is replaced by sender and the sender is a player. It send the message to the sender (player) and console.

Steps to Reproduce

command /test:
  trigger:
    send "hey! it is a test :)" to player and console

Errors / Screenshots

https://pastebin.com/hBULXqcf

Server Information

  • Server version/platform: Spigot 1.8.8
  • Skript version: 2.5.3 fork for 1.8
@TPGamesNL
Copy link
Member

Can confirm.

Caused by Utils#getSuperType(Class...) not returning the right supertype (returns java.lang.Object, should be org.bukkit.command.CommandSender) for the input:

class org.bukkit.entity.Player

extends org.bukkit.entity.HumanEntity

extends org.bukkit.entity.LivingEntity

extends org.bukkit.entity.Damageable

extends org.bukkit.entity.Entity

extends org.bukkit.command.CommandSender

and

class com.destroystokyo.paper.console.TerminalConsoleCommandSender:

extends org.bukkit.craftbukkit.v1_16_R3.command.CraftConsoleCommandSender

implements org.bukkit.command.ConsoleCommandSender

extends org.bukkit.command.CommandSender

@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Mar 28, 2021
@AyhamAl-Ali AyhamAl-Ali mentioned this issue Jul 3, 2021
@TPGamesNL TPGamesNL added PR available Issues which have a yet-to-be merged PR resolving it completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

3 participants