Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling command cooldown doesn't work after a delay #4311

Closed
1 task done
AlexStavrev opened this issue Aug 31, 2021 · 0 comments
Closed
1 task done

Cancelling command cooldown doesn't work after a delay #4311

AlexStavrev opened this issue Aug 31, 2021 · 0 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@AlexStavrev
Copy link

Skript/Server Version

image

Bug Description

cancel the cooldown does not remove the command cooldown if there has been a delay (e.g wait 1 tick)

Expected Behavior

The command cooldown should've been cancelled

Steps to Reproduce

use cancel the cooldown on a command after a delay wait 1 tick
Example code:

# A not working cancelling
command /testCooldown:
	cooldown message: &cYou are under cooldown for &4%remaining time%
	cooldown: 30 seconds
	trigger:
		wait 1 tick
		cancel the cooldown
		send "&dExecuting /testCooldown"

# Working cancelling
command /testCooldown2:
	cooldown: 999 days
	trigger:
		cancel the cooldown
		send "&aExecuting /testCooldown2"

Errors or Screenshots

image

Other

Previous discussion in the #skript-proposals channel in the Discord
image

Agreement

  • I have read the guidelines above and confirm I am following them with this report.
@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Sep 1, 2021
@TPGamesNL TPGamesNL added PR available Issues which have a yet-to-be merged PR resolving it completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

3 participants