Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage cause was #4347

Closed
1 task done
TheLimeGlass opened this issue Oct 2, 2021 · 5 comments
Closed
1 task done

Damage cause was #4347

TheLimeGlass opened this issue Oct 2, 2021 · 5 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@TheLimeGlass
Copy link
Collaborator

Suggestion

Damage cause doesn't have a past self

Why?

Damage cause needs a past tense to make the statement make more sense in English.

damage cause was a projectile

Other

qM8cjYd

Agreement

  • I have read the guidelines above and confirm I am following them with this suggestion.
@Th-Underscore
Copy link

What about this condition?

@TheLimeGlass
Copy link
Collaborator Author

What about this condition?

It's an alternative, but this still errors.

@TPGamesNL
Copy link
Member

Why does it make sense in English (also why damage cause but not other event values)?

@TPGamesNL TPGamesNL added the waiting for reply The report needs a response from the reporter to determine course of action. label Oct 3, 2021
@TheLimeGlass
Copy link
Collaborator Author

TheLimeGlass commented Oct 3, 2021

Why does it make sense in English (also why damage cause but not other event values)?

That error is not from me. Someone else caused it, meaning it's more likely to happen. Damage cause is an expression and when referring to it, it's what caused the event to happen making the user write the statement as past tense.

Support for this should be added.

I believe this can be done just by overriding the setTime and return true if it's past or present.

@TPGamesNL
Copy link
Member

I think it'd be fine to change this, because the damage cause condition linked above also has the past tense in its syntax, so this should also be available to the damage cause expression.

@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). and removed waiting for reply The report needs a response from the reporter to determine course of action. labels Oct 4, 2021
@TPGamesNL TPGamesNL added PR available Issues which have a yet-to-be merged PR resolving it completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

4 participants