Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) False negatives when player's tool is air/not set #4407

Closed
1 task done
MovesLikeJaeger opened this issue Nov 4, 2021 · 5 comments
Closed
1 task done

(Bug) False negatives when player's tool is air/not set #4407

MovesLikeJaeger opened this issue Nov 4, 2021 · 5 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Comments

@MovesLikeJaeger
Copy link

Skript/Server Version

Skript 2.6 (Official Release)
Paper 1.17

Bug Description

image

Same thing happens with if player's tool is set/not set
The photo shows everything ya need to know :D

Expected Behavior

Definitely something funky going on here (This may be related to my last opened issue, but I figured it was still worth mentioning as it is considerably different).

Steps to Reproduce

N/A

Errors or Screenshots

N/A

Other

Worth mentioning that this may be related to #4403

Thanks for all your work guys!

Agreement

  • I have read the guidelines above and confirm I am following them with this report.
@TPGamesNL
Copy link
Member

I don't see the issue, assuming you're holding dirt for all the effect commands
image

@TPGamesNL TPGamesNL added the waiting for reply The report needs a response from the reporter to determine course of action. label Nov 4, 2021
@MovesLikeJaeger
Copy link
Author

MovesLikeJaeger commented Nov 4, 2021

Sorry for the confusion.

I was holding dirt in the top two, and air in the bottom two. Dirt obviously is working correctly.
But when I am holding air, it will broadcast that I'm holding air when I check that I don't have air in my hand, and vise versa.

I don't see the issue, assuming you're holding dirt for all the effect commands image

@TPGamesNL
Copy link
Member

TPGamesNL commented Nov 4, 2021

I can confirm in 2.6, but not on the master branch, so this was most likely fixed in #4162

PS, player's tool is set always returns true, whether you're holding air or not

@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. and removed waiting for reply The report needs a response from the reporter to determine course of action. labels Nov 4, 2021
@MovesLikeJaeger
Copy link
Author

MovesLikeJaeger commented Nov 4, 2021

I can confirm in 2.6, but not on the master branch, so this was most likely fixed in #4162

PS, player's tool is set always returns true, whether you're holding air or not

Good to hear. Thanks.

I also meant
if player's tool is not set
As that would not pass condition when holding nothing. I'd assume that's also fixed with the issue you mentioned though?

Edit:
Oof my bad, it's a late night for me 😅
Thank you!

@TPGamesNL
Copy link
Member

No, that's intended, because you're holding air

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.
Projects
None yet
Development

No branches or pull requests

3 participants