Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error getting the number of items in the player's inventory #4643

Closed
1 task done
NikeiPr1son opened this issue Mar 5, 2022 · 2 comments
Closed
1 task done

Error getting the number of items in the player's inventory #4643

NikeiPr1son opened this issue Mar 5, 2022 · 2 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. legacy versions Issues or PRs which are only applicable for the server versions 1.9-1.12 priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@NikeiPr1son
Copy link

Skript/Server Version

https://pastenow.ru/4ded59b394014ff7c5b4ea07b3ad4677

Bug Description

Writing the sale of items, I had an error with getting the number of items in the inventory. In version 2.6.1 of the plugin, it returns not quite correctly, which cannot be said about 2.5.3

Expected Behavior

In plugin version 2.6.1 I think the values ​​should be returned more precise than 64 and 128. In plugin version 2.5.3 everything works fine. Please see my code, and screenshots of the accompanying version results.

My code: https://pastenow.ru/9d54f588ba581c892e4f17f07490364c

2.6.1: https://pastenow.ru/4ded59b394014ff7c5b4ea07b3ad4677
2.5.3: https://pastenow.ru/c163613a59c6f0b2b964bca92df0cd90

Steps to Reproduce

In plugin version 2.6.1 I think the values ​​should be returned more precise than 64 and 128. In plugin version 2.5.3 everything works fine.

Errors or Screenshots

No response

Other

If this is a bug in version 1.12.2, then I understand everything, but still, please fix it.
If this is possible to implement on version 1.12.2, please update the plugin in releases if possible. Thanks!

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@APickledWalrus APickledWalrus self-assigned this Mar 5, 2022
@AyhamAl-Ali AyhamAl-Ali added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. legacy versions Issues or PRs which are only applicable for the server versions 1.9-1.12 priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Mar 5, 2022
@AyhamAl-Ali
Copy link
Member

Was able to reproduce on 1.12.2 but not on 1.16.5

1.12.2
image

1.16.5
image

@APickledWalrus
Copy link
Member

Likely caused by #4162

@APickledWalrus APickledWalrus mentioned this issue Mar 6, 2022
Merged
@APickledWalrus APickledWalrus added the PR available Issues which have a yet-to-be merged PR resolving it label Mar 6, 2022
@TPGamesNL TPGamesNL added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. legacy versions Issues or PRs which are only applicable for the server versions 1.9-1.12 priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AyhamAl-Ali @APickledWalrus @TPGamesNL @NikeiPr1son