Change EventValues class to be using Converter instead of Getter #5006
Labels
completed
The issue has been fully resolved and the change will be in the next Skript update.
core task
Tasks that may be handled only by the core developer team.
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Suggestion
Getter doesn't allow for Java lambdas, and most Skript classes use Converter directly.
This will allow for
Tested this and it works fine with Getter support for older implementations and Getter extends Converter.
Note that the generics are swapped between the Getter and Converter classes, still no issue as Getter handles this for the Converter implementation.
While whoever is inside the EventValues class, ensure that EVERY CALLING OF EventValueInfo fields are using the getter instead of the raw field direct access. Skript has getters in this class, but never actually uses them... Skript needs to stop doing this for security handling.
Why?
Simplifies the code, easier to read, faster to code, added support for those that want to use Java 8 lambdas.
The text was updated successfully, but these errors were encountered: