Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemType with enchantments expression #6522

Closed
1 task done
ShaneBeee opened this issue Apr 2, 2024 · 3 comments
Closed
1 task done

ItemType with enchantments expression #6522

ShaneBeee opened this issue Apr 2, 2024 · 3 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for PR available Issues which have a yet-to-be merged PR resolving it priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@ShaneBeee
Copy link
Contributor

Suggestion

I would like to suggest adding an expression, something like:
%itemtypes% (of|enchanted with) %enchantmenttypes%

Why?

Quite often when people ask for the docs on how to enchant items, we have to send them the confusing ItemType type doc.
Its not the easiest one to read.

On top of that, people try do:
diamond sword named "bob" of sharpness 10
or
{_item} of sharpness 10
We then have to explain the order/literal issues.

This expression would help alleviate that pressure.

I considered whipping up a PR but wanted feedback before putting the time/effort in.

Other

I still like turtles 🐢

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@Moderocky Moderocky added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. good first issue An issue that would be good for a first-time contributor to make a PR for labels Apr 2, 2024
@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Apr 2, 2024 •
edited
Loading

Hey! Hey! Hey! more reasons to continue working on my stale PRs ⚡️ see #4366

@AyhamAl-Ali AyhamAl-Ali added PR available Issues which have a yet-to-be merged PR resolving it and removed good first issue An issue that would be good for a first-time contributor to make a PR for labels Apr 2, 2024
@Moderocky
Copy link
Member

I dont think we should mark this PR-available if the PR is a stale draft because somebody else might want to do it.

@Moderocky Moderocky added good first issue An issue that would be good for a first-time contributor to make a PR for and removed PR available Issues which have a yet-to-be merged PR resolving it labels Apr 3, 2024
@AyhamAl-Ali AyhamAl-Ali added the PR available Issues which have a yet-to-be merged PR resolving it label Apr 5, 2024
@AyhamAl-Ali
Copy link
Member

ops, duplicate of #1836

@AyhamAl-Ali AyhamAl-Ali closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for PR available Issues which have a yet-to-be merged PR resolving it priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Moderocky @ShaneBeee @AyhamAl-Ali