fix: boolean operator fix (#23) #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ll wait for @Syst3ms to reply for this one. |
Matocolotoe
reviewed
Oct 25, 2020
src/main/java/io/github/syst3ms/skriptparser/parsing/SyntaxParser.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Giovanni <42092549+Matocolotoe@users.noreply.github.com>
Olyno
previously approved these changes
Oct 25, 2020
Syst3ms
suggested changes
Nov 1, 2020
src/main/java/io/github/syst3ms/skriptparser/parsing/SyntaxParser.java
Outdated
Show resolved
Hide resolved
added 3 commits
November 1, 2020 16:22
Syst3ms
reviewed
Nov 1, 2020
| @@ -64,6 +64,12 @@ | |||
| // Gradle requires the cast, but IntelliJ considers it redundant | |||
| public static final PatternType<Object> OBJECTS_PATTERN_TYPE = new PatternType<>((Type<Object>) TypeManager.getByClass(Object.class).orElseThrow(AssertionError::new), false); | |||
|
|
|||
| public static final ExpressionInfo<ExprBooleanOperators, Boolean> EXPRESSION_BOOLEANOPERATORS | |||
There was a problem hiding this comment.
Might need some testing to check that this isn't being initialized until after registration.
There was a problem hiding this comment.
I did some testing and no errors appear, which is normal considering we don't use the class until after registration. Unless we change things drastically in the future, this should be fine.
Syst3ms
reviewed
Nov 2, 2020
src/main/java/io/github/syst3ms/skriptparser/parsing/SyntaxParser.java
Outdated
Show resolved
Hide resolved
Syst3ms
suggested changes
Nov 7, 2020
Syst3ms
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23.
This is a small fix for the bug described in the above issue.
Basically, expression parsing now goes as follows:
This means boolean operators will now have priority, which was needed in the expression. If you still want to use a boolean list (why, I don't know...), you can just paste 'list' in front of your expression to force-parse it as a list.
Note that these changes are propositional and that any suggestions are welcome. This is just my take on the problem. I think changing the whole list syntax is a bit over the top for such a small issue.
Let me know if you are satisfied with the 'list' prefix as well.