Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't call functions inside of custom syntax #69

Closed
TheBentoBox opened this issue May 13, 2023 · 5 comments
Closed

Can't call functions inside of custom syntax #69

TheBentoBox opened this issue May 13, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@TheBentoBox
Copy link
Member

Describe the bug
When running with Skript 2.7.0-beta2, function calls inside of custom syntax no longer parse. This happens both on the initial load and on subsequent reloads of the script. It does not matter if the function is in the same script or a different script, or whether or not it is local.

To reproduce

  1. Create a function.
  2. Create custom syntax.
  3. Try to call that function within the custom syntax (e.g., myExampleFunction()).

Expected behavior
The function call should parse and should run when your custom syntax is triggered.

Screenshots
Example with a minimalist server setup. See VS Code sidebar, Skript + skript-reflect are my only plugins (as well as the patcher agent).

image
image

Server information

  • skript-reflect: 2.3.0
  • Skript: 2.7.0-beta2
  • Bukkit: 1.19.4 (running Purpur build 1968, for what that's worth)
  • Minecraft: 1.19.4
  • Java: 17.0.6
  • OS: Windows 11
@L3v3lup
Copy link

L3v3lup commented Jun 30, 2023

I believe this is linked to the same problem here:
SkriptLang/Skript#5779

With 1.20 released, this gets a bit more important.

@TPGamesNL TPGamesNL added the bug Something isn't working label Jul 18, 2023
@TPGamesNL
Copy link
Member

Fix delayed at least until SkriptLang/Skript#5669 is merged, as this PR finalizes the Structure API, which is what skript-reflect will be using.

@rudde0
Copy link

rudde0 commented Sep 9, 2023

Fix delayed at least until SkriptLang/Skript#5669 is merged, as this PR finalizes the Structure API, which is what skript-reflect will be using.

Could you fix it now?

@envizar
Copy link

envizar commented Oct 10, 2023

Fix delayed at least until SkriptLang/Skript#5669 is merged, as this PR finalizes the Structure API, which is what skript-reflect will be using.

@TPGamesNL Will you fix this issue?

@TPGamesNL
Copy link
Member

I will when I have time, i.e. not soon. Anyone is free to make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants