Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the incoming skylinks to V1 only? #5

Open
ro-tex opened this issue Nov 26, 2021 · 0 comments
Open

Restrict the incoming skylinks to V1 only? #5

ro-tex opened this issue Nov 26, 2021 · 0 comments
Assignees

Comments

@ro-tex
Copy link
Collaborator

ro-tex commented Nov 26, 2021

If we put the requirement on the caller we can avoid this code here. If we increase the recursive depth of the v2 skylink in the future we will need to remember to update this too. That is probably a good reason to just restrict the scanner to only accept v1 skylinks. The portal should have the v1 skylink anyways by the end of the request. And the scanner won't be scanning before the request completes anyways so we don't lose anything by waiting at the portal level.

The skylink would only not be added if the portal crashed/exited before the request is complete which would mean the user didn't get the full request anyways.

Originally posted by @MSevey in #1 (comment)

@ro-tex ro-tex mentioned this issue Nov 26, 2021
5 tasks
@MSevey MSevey removed their assignment Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants