Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement filtering feature for /uploads and /downloads enpoints #154

Open
meeh0w opened this issue Mar 16, 2022 · 2 comments · May be fixed by #180
Open

Implement filtering feature for /uploads and /downloads enpoints #154

meeh0w opened this issue Mar 16, 2022 · 2 comments · May be fixed by #180
Assignees
@ro-tex
Labels
enhancement New feature or request

Comments

@meeh0w
Copy link

meeh0w commented Mar 16, 2022 •
edited
Loading

Overview

For the new Account Dashboard, we need a way to filter and sort the uploaded and downloaded files on /uploads and /downloads endpoints.

Needed filters:

  • by file name
  • by skylink
  • by file type
  • excluding "small files" (/cc @ChrisSchinnerl what do we consider a "small file"?)

Needed sort orders:

  • by file name
  • by size
  • by upload/download date

image
@meeh0w meeh0w added the enhancement New feature or request label Mar 16, 2022
@ro-tex ro-tex mentioned this issue Mar 31, 2022
Closed
@ro-tex
Copy link
Contributor

ro-tex commented Mar 31, 2022 •
edited
Loading

@meeh0w can you give me the specific column names you want to use, i.e. filename for file name? If not, I can define them, that's also fine by me.

As discussed previously, we don't have file type information for skylnks, so implementing sorting on that will not be possible at this time. If we decide that we need this kind of information (and the sorting), we can implement that under a separate issue but such a change is very much out of scope for this one. cc @ChrisSchinnerl

Also out of scope is the filtering of small files. That features is not fully designed, so I have created a separate issue for it in #179.

@ro-tex ro-tex linked a pull request Mar 31, 2022 that will close this issue
Draft
5 tasks
@meeh0w
Copy link
Author

meeh0w commented Apr 1, 2022 •
edited
Loading

@ro-tex Well, I didn't expect the column names to change with this feature. I'd keep them consistent with GET /user/uploads response, so frontend is prepared to use:

  • id
  • name
  • size
  • skylink
  • uploadedOn

@ro-tex ro-tex changed the title Implement filtering feature for /uploads and /downloads enpoints [don't implement] Implement filtering feature for /uploads and /downloads enpoints Apr 6, 2022
@ro-tex ro-tex added invalid This doesn't seem right and removed invalid This doesn't seem right labels Apr 6, 2022
@ro-tex ro-tex changed the title [don't implement] Implement filtering feature for /uploads and /downloads enpoints Implement filtering feature for /uploads and /downloads enpoints Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ro-tex ro-tex

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search and ordering of uploads SkynetLabs/skynet-accounts
2 participants
@ro-tex @meeh0w