Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f/u: normalizeDayOfMonth more readable signature #184

Closed
ro-tex opened this issue Apr 4, 2022 · 0 comments · Fixed by #189
Closed

f/u: normalizeDayOfMonth more readable signature #184

ro-tex opened this issue Apr 4, 2022 · 0 comments · Fixed by #189

Comments

@ro-tex
Copy link
Contributor

ro-tex commented Apr 4, 2022

f/u

This is a bit confusing. It says "whether the current month has the given day" but there is a month and a current input. So I'd either split it up into currentMonth and currentYear inputs or have current and then inside the function pull out the month.

Originally posted by @ChrisSchinnerl in #177 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give normalizeDayOfMonth a more readable signature. SkynetLabs/skynet-accounts
1 participant
@ro-tex