Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Add ts-ify pipeline into build command #75

Open
dghelm opened this issue Apr 30, 2021 · 2 comments
Open

Add ts-ify pipeline into build command #75

dghelm opened this issue Apr 30, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dghelm
Copy link
Contributor

dghelm commented Apr 30, 2021

We should auto-build the browser version for script-tag imports on build, or give it an additional build command.

We'd need to add browserify, tsify and uglifyjs to dev dependencies. Need to look into package.json usage or config files, but the browser commandline is:

browserify ./src/index.ts -s skynet -p [ tsify --noImplicitAny ] > ./dist/browser/index.js
uglifyjs ./dist/browser/index.js -o ./dist/browser/index.min.js -c -m

@dghelm dghelm added the enhancement New feature or request label Apr 30, 2021
@mrcnski
Copy link
Contributor

mrcnski commented Apr 30, 2021

Note that the webpack branch already builds bundles for script-tag imports. I'm not sure what the pros/cons of webpack vs. browserify are. At this point, much of the webpack branch may be obsolete anyway.

@dghelm
Copy link
Contributor Author

dghelm commented Apr 30, 2021

True, I'm not sure what the merge will look like, but Parox also sent this over, which may be a nice direction to move: https://tsdx.io/

I think this is probably a farther-off to-do that we can look at with nodejs (and command-line!) additions to the SDK.

@mrcnski mrcnski added the help wanted Extra attention is needed label Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants