diff --git a/UNRELEASED.md b/UNRELEASED.md index b7384859db..ebf4bdae1f 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -4,3 +4,7 @@ - react-native-bpk-component-text: - Remove warning about invalid prop type usage. + +- react-native-bpk-component-text-input: +- react-native-bpk-component-phone-number-input: + - Removed line height to fix an issue where overflowing content didn't scroll correctly. diff --git a/native/packages/react-native-bpk-component-phone-input/src/__snapshots__/BpkPhoneNumberInput-test.android.js.snap b/native/packages/react-native-bpk-component-phone-input/src/__snapshots__/BpkPhoneNumberInput-test.android.js.snap index 981f1d71fe..807a505aa2 100644 --- a/native/packages/react-native-bpk-component-phone-input/src/__snapshots__/BpkPhoneNumberInput-test.android.js.snap +++ b/native/packages/react-native-bpk-component-phone-input/src/__snapshots__/BpkPhoneNumberInput-test.android.js.snap @@ -167,7 +167,6 @@ exports[`Android BpkPhoneNumberInput should render correctly 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -352,7 +351,6 @@ exports[`Android BpkPhoneNumberInput should render correctly with \`editable\` f "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, diff --git a/native/packages/react-native-bpk-component-phone-input/src/__snapshots__/BpkPhoneNumberInput-test.ios.js.snap b/native/packages/react-native-bpk-component-phone-input/src/__snapshots__/BpkPhoneNumberInput-test.ios.js.snap index 325c52cf4b..c6434fed1a 100644 --- a/native/packages/react-native-bpk-component-phone-input/src/__snapshots__/BpkPhoneNumberInput-test.ios.js.snap +++ b/native/packages/react-native-bpk-component-phone-input/src/__snapshots__/BpkPhoneNumberInput-test.ios.js.snap @@ -184,7 +184,6 @@ exports[`iOS BpkPhoneNumberInput should render correctly 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -386,7 +385,6 @@ exports[`iOS BpkPhoneNumberInput should render correctly with \`editable\` false "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, diff --git a/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-RTL-test.js.snap b/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-RTL-test.js.snap index d094f82918..cc518d1887 100644 --- a/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-RTL-test.js.snap +++ b/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-RTL-test.js.snap @@ -63,7 +63,6 @@ exports[`RTL BpkTextInput should ignore when placeholder is provided, as element "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -141,7 +140,6 @@ exports[`RTL BpkTextInput should render correctly 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -221,7 +219,6 @@ exports[`RTL BpkTextInput should render correctly with \`accessoryView\` 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -299,7 +296,6 @@ exports[`RTL BpkTextInput should render correctly with arbitrary props 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -380,7 +376,6 @@ exports[`RTL BpkTextInput should render correctly with custom style 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -458,7 +453,6 @@ exports[`RTL BpkTextInput should render correctly with description 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -559,7 +553,6 @@ exports[`RTL BpkTextInput should render correctly with description, valid=false "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -689,7 +682,6 @@ exports[`RTL BpkTextInput should render correctly with editable=false 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -767,7 +759,6 @@ exports[`RTL BpkTextInput should render correctly with inputRef set 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -845,7 +836,6 @@ exports[`RTL BpkTextInput should render correctly with mask="99/99" 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -923,7 +913,6 @@ exports[`RTL BpkTextInput should render correctly with mask="9999-9999-9999-9999 "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1001,7 +990,6 @@ exports[`RTL BpkTextInput should render correctly with valid 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1108,7 +1096,6 @@ exports[`RTL BpkTextInput should render correctly with valid false 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1215,7 +1202,6 @@ exports[`RTL BpkTextInput should render correctly with valid false and a validat "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1345,7 +1331,6 @@ exports[`RTL BpkTextInput should render correctly with value 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, diff --git a/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-test.android.js.snap b/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-test.android.js.snap index 320df1ff25..baf7e28915 100644 --- a/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-test.android.js.snap +++ b/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-test.android.js.snap @@ -63,7 +63,6 @@ exports[`Android BpkTextInput should ignore when placeholder is provided, as ele "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -141,7 +140,6 @@ exports[`Android BpkTextInput should render correctly 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -221,7 +219,6 @@ exports[`Android BpkTextInput should render correctly with \`accessoryView\` 1`] "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -299,7 +296,6 @@ exports[`Android BpkTextInput should render correctly with arbitrary props 1`] = "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -380,7 +376,6 @@ exports[`Android BpkTextInput should render correctly with custom style 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -458,7 +453,6 @@ exports[`Android BpkTextInput should render correctly with description 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -559,7 +553,6 @@ exports[`Android BpkTextInput should render correctly with description, valid=fa "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -689,7 +682,6 @@ exports[`Android BpkTextInput should render correctly with editable=false 1`] = "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -767,7 +759,6 @@ exports[`Android BpkTextInput should render correctly with inputRef set 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -845,7 +836,6 @@ exports[`Android BpkTextInput should render correctly with mask="99/99" 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -923,7 +913,6 @@ exports[`Android BpkTextInput should render correctly with mask="9999-9999-9999- "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1001,7 +990,6 @@ exports[`Android BpkTextInput should render correctly with valid 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1108,7 +1096,6 @@ exports[`Android BpkTextInput should render correctly with valid false 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1215,7 +1202,6 @@ exports[`Android BpkTextInput should render correctly with valid false and a val "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1345,7 +1331,6 @@ exports[`Android BpkTextInput should render correctly with value 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, diff --git a/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-test.ios.js.snap b/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-test.ios.js.snap index b863aac20b..0b5ef2a30a 100644 --- a/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-test.ios.js.snap +++ b/native/packages/react-native-bpk-component-text-input/src/__snapshots__/BpkTextInput-test.ios.js.snap @@ -63,7 +63,6 @@ exports[`iOS BpkTextInput should ignore when placeholder is provided, as element "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -141,7 +140,6 @@ exports[`iOS BpkTextInput should render correctly 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -221,7 +219,6 @@ exports[`iOS BpkTextInput should render correctly with \`accessoryView\` 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -299,7 +296,6 @@ exports[`iOS BpkTextInput should render correctly with arbitrary props 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -380,7 +376,6 @@ exports[`iOS BpkTextInput should render correctly with custom style 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -458,7 +453,6 @@ exports[`iOS BpkTextInput should render correctly with description 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -559,7 +553,6 @@ exports[`iOS BpkTextInput should render correctly with description, valid=false "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -689,7 +682,6 @@ exports[`iOS BpkTextInput should render correctly with editable=false 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -767,7 +759,6 @@ exports[`iOS BpkTextInput should render correctly with inputRef set 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -845,7 +836,6 @@ exports[`iOS BpkTextInput should render correctly with mask="99/99" 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -923,7 +913,6 @@ exports[`iOS BpkTextInput should render correctly with mask="9999-9999-9999-9999 "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1001,7 +990,6 @@ exports[`iOS BpkTextInput should render correctly with valid 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1108,7 +1096,6 @@ exports[`iOS BpkTextInput should render correctly with valid false 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1215,7 +1202,6 @@ exports[`iOS BpkTextInput should render correctly with valid false and a validat "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, @@ -1345,7 +1331,6 @@ exports[`iOS BpkTextInput should render correctly with value 1`] = ` "flex": 1, "fontSize": 16, "fontWeight": "400", - "lineHeight": 19, "minHeight": 27, "paddingHorizontal": 0, "paddingVertical": 4, diff --git a/native/packages/react-native-bpk-component-text-input/src/styles.js b/native/packages/react-native-bpk-component-text-input/src/styles.js index 9ddea31a52..c6be007fbc 100644 --- a/native/packages/react-native-bpk-component-text-input/src/styles.js +++ b/native/packages/react-native-bpk-component-text-input/src/styles.js @@ -67,7 +67,6 @@ const styles = StyleSheet.create({ minHeight, fontSize: textBaseFontSize, fontWeight: textBaseFontWeight, - lineHeight: lineHeightBase, color: colorGray700, borderBottomWidth: 0, textAlign: I18nManager.isRTL ? 'right' : 'left',